From: Steven Rostedt <rostedt@goodmis.org>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Ingo Molnar <mingo@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: kernel-trace: Fine-tuning for seven function implementations
Date: Tue, 23 May 2017 05:18:06 +0000 [thread overview]
Message-ID: <20170523011806.160592bc@vmware.local.home> (raw)
In-Reply-To: <71dfc742-c90d-e12b-83a0-424d9c51ac35@users.sourceforge.net>
On Mon, 22 May 2017 09:45:27 +0200
SF Markus Elfring <elfring@users.sourceforge.net> wrote:
> > I wont be touching or even looking at these until after 4.12-rc1 is
> > released. Feel free to reply to this email with a ping in a week or
> > two.
>
> *ping*
>
> How do you think about to give these update suggestions another look?
>
The conversions of the seq_printf()s and friends are fine, but the rest
are not worth the churn. Yes checkpatch may complain about the NULL
compares and the kallocs(), but that's for new code, not for code that
has already been accepted.
-- Steve
next prev parent reply other threads:[~2017-05-23 5:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 21:00 [PATCH 0/7] kernel-trace: Fine-tuning for seven function implementations SF Markus Elfring
2017-05-05 21:01 ` [PATCH 1/7] kernel-trace: Combine two function calls into one in hist_trigger_entry_print() SF Markus Elfring
2017-05-05 21:02 ` [PATCH 2/7] kernel-trace: Replace five seq_puts() calls by seq_putc() SF Markus Elfring
2017-05-05 21:03 ` [PATCH 3/7] kernel-trace: Adjust two checks for null pointers in compatible_field() SF Markus Elfring
2017-05-23 5:15 ` Steven Rostedt
2017-05-05 21:04 ` [PATCH 4/7] kernel-trace: Improve a size determination in create_hist_field() SF Markus Elfring
2017-05-05 21:05 ` [PATCH 5/7] kernel-trace: Replace two seq_printf() calls by seq_puts() in probes_seq_show() SF Markus Elfring
2017-05-05 21:06 ` [PATCH 0/7] kernel-trace: Fine-tuning for seven function implementations Steven Rostedt
2017-05-05 21:21 ` SF Markus Elfring
2017-05-22 7:45 ` SF Markus Elfring
2017-05-23 5:18 ` Steven Rostedt [this message]
2017-05-05 21:06 ` [PATCH 6/7] kernel-trace: Adjust two checks for null pointers in uprobe_buffer_init() SF Markus Elfring
2017-05-05 21:09 ` SF Markus Elfring
2017-05-05 21:10 ` [PATCH 7/7] kernel-trace: Delete an error message for a failed memory allocation in create_trace_upr SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523011806.160592bc@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox