From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Evgeniy Polyakov <zbr@ioremap.net>,
Sebastian Reichel <sre@kernel.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] w1: Add subsystem kernel public interface
Date: Sat, 03 Jun 2017 10:22:33 +0000 [thread overview]
Message-ID: <20170603102233.GA19112@kroah.com> (raw)
In-Reply-To: <20170516200814.12360-2-afd@ti.com>
On Tue, May 16, 2017 at 03:08:14PM -0500, Andrew F. Davis wrote:
> Like other subsystems we should be able to define slave devices outside
> of the w1 directory. To do this we move public facing interface
> definitions to include/linux/w1.h and rename the internal definition
> file to w1_internal.h.
>
> As w1_family.h and w1_int.h contained almost entirely public
> driver interface definitions we simply removed these files and
> moved the remaining definitions into w1_internal.h.
>
> With this we can now start to move slave devices out of w1/slaves and
> into the subsystem based on the function they implement, again like
> other drivers.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> Reviewed-by: Sebastian Reichel <sre@kernel.org>
This breaks the build for me:
CC [M] drivers/power/supply/ds2760_battery.o
drivers/power/supply/ds2760_battery.c:31:10: fatal error: ../../w1/w1.h: No such file or directory
#include "../../w1/w1.h"
^~~~~~~~~~~~~~~
compilation terminated.
So there was w1 drivers outside of the drivers/w1/ directory :)
Please fix and resend.
thanks,
greg k-h
next prev parent reply other threads:[~2017-06-03 10:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170516200814.12360-1-afd@ti.com>
2017-05-16 20:08 ` [PATCH v2 1/1] w1: Add subsystem kernel public interface Andrew F. Davis
2017-05-25 13:00 ` Greg Kroah-Hartman
2017-05-25 13:07 ` Andrew F. Davis
[not found] ` <1499591495717767@web38g.yandex.ru>
2017-05-25 13:21 ` Andrew F. Davis
[not found] ` <1604131495718924@web38g.yandex.ru>
2017-05-25 13:47 ` Andrew F. Davis
[not found] ` <3947221495815182@web23o.yandex.ru>
2017-05-26 16:31 ` Andrew F. Davis
2017-06-03 10:22 ` Greg Kroah-Hartman [this message]
2017-06-05 13:57 ` Andrew F. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170603102233.GA19112@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=afd@ti.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sre@kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox