* [PATCH] thunderbolt: Fix reset response_type
@ 2017-06-14 7:47 Dan Carpenter
2017-06-14 8:42 ` Mika Westerberg
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2017-06-14 7:47 UTC (permalink / raw)
To: Andreas Noever, Mika Westerberg
Cc: Michael Jamet, Yehezkel Bernat, linux-kernel, kernel-janitors
There is a mistake here where we accidentally use sizeof(TB_CFG_PKG_RESET)
instead of just TB_CFG_PKG_RESET. The size of an int is 4 so it's the
same as TB_CFG_PKG_NOTIFY_ACK.
Fixes: d7f781bfdbf4 ("thunderbolt: Rework control channel to be more reliable")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c
index 69c0232a22f8..fb40dd0588b9 100644
--- a/drivers/thunderbolt/ctl.c
+++ b/drivers/thunderbolt/ctl.c
@@ -804,7 +804,7 @@ struct tb_cfg_result tb_cfg_reset(struct tb_ctl *ctl, u64 route,
req->request_type = TB_CFG_PKG_RESET;
req->response = &reply;
req->response_size = sizeof(reply);
- req->response_type = sizeof(TB_CFG_PKG_RESET);
+ req->response_type = TB_CFG_PKG_RESET;
res = tb_cfg_request_sync(ctl, req, timeout_msec);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] thunderbolt: Fix reset response_type
2017-06-14 7:47 [PATCH] thunderbolt: Fix reset response_type Dan Carpenter
@ 2017-06-14 8:42 ` Mika Westerberg
2017-06-14 9:10 ` Andreas Noever
0 siblings, 1 reply; 3+ messages in thread
From: Mika Westerberg @ 2017-06-14 8:42 UTC (permalink / raw)
To: Dan Carpenter
Cc: Andreas Noever, Michael Jamet, Yehezkel Bernat, linux-kernel,
kernel-janitors
On Wed, Jun 14, 2017 at 10:47:21AM +0300, Dan Carpenter wrote:
> There is a mistake here where we accidentally use sizeof(TB_CFG_PKG_RESET)
> instead of just TB_CFG_PKG_RESET. The size of an int is 4 so it's the
> same as TB_CFG_PKG_NOTIFY_ACK.
>
> Fixes: d7f781bfdbf4 ("thunderbolt: Rework control channel to be more reliable")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Good catch!
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] thunderbolt: Fix reset response_type
2017-06-14 8:42 ` Mika Westerberg
@ 2017-06-14 9:10 ` Andreas Noever
0 siblings, 0 replies; 3+ messages in thread
From: Andreas Noever @ 2017-06-14 9:10 UTC (permalink / raw)
To: Mika Westerberg, Dan Carpenter, Greg KH
Cc: Michael Jamet, Yehezkel Bernat, linux-kernel@vger.kernel.org,
kernel-janitors
On Wed, Jun 14, 2017 at 10:42 AM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> On Wed, Jun 14, 2017 at 10:47:21AM +0300, Dan Carpenter wrote:
>> There is a mistake here where we accidentally use sizeof(TB_CFG_PKG_RESET)
>> instead of just TB_CFG_PKG_RESET. The size of an int is 4 so it's the
>> same as TB_CFG_PKG_NOTIFY_ACK.
>>
>> Fixes: d7f781bfdbf4 ("thunderbolt: Rework control channel to be more reliable")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Good catch!
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Andreas Noever <andreas.noever@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-14 9:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-14 7:47 [PATCH] thunderbolt: Fix reset response_type Dan Carpenter
2017-06-14 8:42 ` Mika Westerberg
2017-06-14 9:10 ` Andreas Noever
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox