From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Date: Wed, 14 Jun 2017 08:42:53 +0000 Subject: Re: [PATCH] thunderbolt: Fix reset response_type Message-Id: <20170614084253.GZ3187@lahna.fi.intel.com> List-Id: References: <20170614074720.GA29175@elgon.mountain> In-Reply-To: <20170614074720.GA29175@elgon.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Andreas Noever , Michael Jamet , Yehezkel Bernat , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Wed, Jun 14, 2017 at 10:47:21AM +0300, Dan Carpenter wrote: > There is a mistake here where we accidentally use sizeof(TB_CFG_PKG_RESET) > instead of just TB_CFG_PKG_RESET. The size of an int is 4 so it's the > same as TB_CFG_PKG_NOTIFY_ACK. > > Fixes: d7f781bfdbf4 ("thunderbolt: Rework control channel to be more reliable") > Signed-off-by: Dan Carpenter Good catch! Acked-by: Mika Westerberg