* [PATCH] drm/amdkfd: NULL dereference involving create_process()
@ 2017-06-14 10:58 Dan Carpenter
2017-06-14 16:41 ` Deucher, Alexander
2017-06-14 20:34 ` Oded Gabbay
0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-06-14 10:58 UTC (permalink / raw)
To: Oded Gabbay, Alexey Skidanov
Cc: David Airlie, kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Alex Deucher,
Christian König
We accidentally return ERR_PTR(0) which is NULL. The caller is not
expecting that and it leads to an Oops.
Fixes: dd59239a9862 ("amdkfd: init aperture once per process")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
index 84d1ffd1eef9..1190d06884ed 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
@@ -318,7 +318,8 @@ static struct kfd_process *create_process(const struct task_struct *thread)
/* init process apertures*/
process->is_32bit_user_mode = in_compat_syscall();
- if (kfd_init_apertures(process) != 0)
+ err = kfd_init_apertures(process);
+ if (err != 0)
goto err_init_apretures;
return process;
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH] drm/amdkfd: NULL dereference involving create_process()
2017-06-14 10:58 [PATCH] drm/amdkfd: NULL dereference involving create_process() Dan Carpenter
@ 2017-06-14 16:41 ` Deucher, Alexander
2017-06-14 18:34 ` Felix Kuehling
2017-06-14 20:34 ` Oded Gabbay
1 sibling, 1 reply; 4+ messages in thread
From: Deucher, Alexander @ 2017-06-14 16:41 UTC (permalink / raw)
To: 'Dan Carpenter', Oded Gabbay, Alexey Skidanov,
Kuehling, Felix
Cc: Koenig, Christian, David Airlie, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Wednesday, June 14, 2017 6:59 AM
> To: Oded Gabbay; Alexey Skidanov
> Cc: Deucher, Alexander; Koenig, Christian; David Airlie; dri-
> devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; kernel-
> janitors@vger.kernel.org
> Subject: [PATCH] drm/amdkfd: NULL dereference involving create_process()
>
> We accidentally return ERR_PTR(0) which is NULL. The caller is not
> expecting that and it leads to an Oops.
>
> Fixes: dd59239a9862 ("amdkfd: init aperture once per process")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Include Felix.
Alex
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> index 84d1ffd1eef9..1190d06884ed 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> @@ -318,7 +318,8 @@ static struct kfd_process *create_process(const struct
> task_struct *thread)
>
> /* init process apertures*/
> process->is_32bit_user_mode = in_compat_syscall();
> - if (kfd_init_apertures(process) != 0)
> + err = kfd_init_apertures(process);
> + if (err != 0)
> goto err_init_apretures;
>
> return process;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/amdkfd: NULL dereference involving create_process()
2017-06-14 16:41 ` Deucher, Alexander
@ 2017-06-14 18:34 ` Felix Kuehling
0 siblings, 0 replies; 4+ messages in thread
From: Felix Kuehling @ 2017-06-14 18:34 UTC (permalink / raw)
To: Deucher, Alexander, 'Dan Carpenter', Oded Gabbay,
Alexey Skidanov
Cc: Koenig, Christian, David Airlie, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Yeah, I saw this earlier. I'm on the amd-gfx list.
The patch looks good to me. Feel free to add my R-b. Do you want to
apply it to amd-staging-4.11 and drm-next? I can take care of
amd-kfd-staging and the release branches.
Thanks,
Felix
On 17-06-14 12:41 PM, Deucher, Alexander wrote:
> > -----Original Message-----
> > From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> > Sent: Wednesday, June 14, 2017 6:59 AM
> > To: Oded Gabbay; Alexey Skidanov
> > Cc: Deucher, Alexander; Koenig, Christian; David Airlie; dri-
> > devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; kernel-
> > janitors@vger.kernel.org
> > Subject: [PATCH] drm/amdkfd: NULL dereference involving create_process()
> >
> > We accidentally return ERR_PTR(0) which is NULL. The caller is not
> > expecting that and it leads to an Oops.
> >
> > Fixes: dd59239a9862 ("amdkfd: init aperture once per process")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Include Felix.
>
> Alex
>
> >
> > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> > b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> > index 84d1ffd1eef9..1190d06884ed 100644
> > --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> > @@ -318,7 +318,8 @@ static struct kfd_process *create_process(const
> struct
> > task_struct *thread)
> >
> > /* init process apertures*/
> > process->is_32bit_user_mode = in_compat_syscall();
> > - if (kfd_init_apertures(process) != 0)
> > + err = kfd_init_apertures(process);
> > + if (err != 0)
> > goto err_init_apretures;
> >
> > return process;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdkfd: NULL dereference involving create_process()
2017-06-14 10:58 [PATCH] drm/amdkfd: NULL dereference involving create_process() Dan Carpenter
2017-06-14 16:41 ` Deucher, Alexander
@ 2017-06-14 20:34 ` Oded Gabbay
1 sibling, 0 replies; 4+ messages in thread
From: Oded Gabbay @ 2017-06-14 20:34 UTC (permalink / raw)
To: Dan Carpenter
Cc: Alex Deucher, Christian König, David Airlie,
Maling list - DRI developers, amd-gfx list, kernel-janitors,
Kuehling, Felix
On Wed, Jun 14, 2017 at 1:58 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> We accidentally return ERR_PTR(0) which is NULL. The caller is not
> expecting that and it leads to an Oops.
>
> Fixes: dd59239a9862 ("amdkfd: init aperture once per process")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> index 84d1ffd1eef9..1190d06884ed 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> @@ -318,7 +318,8 @@ static struct kfd_process *create_process(const struct task_struct *thread)
>
> /* init process apertures*/
> process->is_32bit_user_mode = in_compat_syscall();
> - if (kfd_init_apertures(process) != 0)
> + err = kfd_init_apertures(process);
> + if (err != 0)
> goto err_init_apretures;
>
> return process;
Hi Dan,
Applied to amdkfd-next
Thanks!
Oded
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-14 20:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-14 10:58 [PATCH] drm/amdkfd: NULL dereference involving create_process() Dan Carpenter
2017-06-14 16:41 ` Deucher, Alexander
2017-06-14 18:34 ` Felix Kuehling
2017-06-14 20:34 ` Oded Gabbay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox