From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Date: Wed, 21 Jun 2017 19:15:12 +0000 Subject: Re: [PATCH] iio: adc: mxs-lradc: Checking IS_ERR() instead of NULL Message-Id: <20170621201512.5808cc8a@kernel.org> List-Id: References: <20170426210349.sjmf65ck5awfgz22@mwanda> <13f3bcd0-c6c8-7abc-d732-91a19618f5a5@kernel.org> <20170613083905.7aiaxvfjg2ypkfq2@mwanda> In-Reply-To: <20170613083905.7aiaxvfjg2ypkfq2@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Ksenija Stanojevic , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Lee Jones , Marek Vasut , linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org On Tue, 13 Jun 2017 11:39:05 +0300 Dan Carpenter wrote: > On Thu, Apr 27, 2017 at 07:21:09AM +0100, Jonathan Cameron wrote: > > On 26/04/17 22:03, Dan Carpenter wrote: > > > devm_ioremap() returns NULL on error. It doesn't return error pointers. > > > > > > Fixes: 6dd112b9f85e ("iio: adc: mxs-lradc: Add support for ADC driver") > > > Signed-off-by: Dan Carpenter > > > > > Hi Dan, > > > > Already another patch for this under review. Open question there is whether > > devm_ioremap_resource is the way to go instead. > > > > I wasn't on that other thread... Nothing appears to have happened with > this or the touchscreen bug either. > > regards, > dan carpenter I think I was just being a bit lax in actually pushing it out and sending Greg a pull request. https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?h=fixes-togreg&id54e15bc28ba94aa5d6b31a83a42d5c03af2a6d Thanks for following up on this. Jonathan > >