From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Mon, 03 Jul 2017 11:09:19 +0000 Subject: [PATCH] PCI: fix pci_try_reset_function() Message-Id: <20170701135323.x5vaj4e2wcs2mcro@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bjorn Helgaas , Christoph Hellwig Cc: linux-pci@vger.kernel.org, kernel-janitors@vger.kernel.org There is a reversed if condition so the function doesn't work. Fixes: e94fae7aeef4 ("PCI: Protect pci_error_handlers->reset_notify() usage with device_lock()") Signed-off-by: Dan Carpenter diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 5b49d662f996..3bf28bf04c3d 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -4269,7 +4269,7 @@ int pci_try_reset_function(struct pci_dev *dev) if (rc) return rc; - if (pci_dev_trylock(dev)) + if (!pci_dev_trylock(dev)) return -EAGAIN; pci_dev_save_and_disable(dev);