Re: [PATCH 4/9] power: supply: axp20x_usb_power: Drop unnecessary static

Sebastian Reichel
2017-05-15T13:25:19Z

[-- Attachment #1: Type: text/plain, Size: 1466 bytes --]

Hi Julia,

On Thu, May 04, 2017 at 10:10:49PM +0200, Julia Lawall wrote:
> Drop static on a local variable, when the variable is either first
> initialized or never used, on every possible execution path through the
> function. The static has no benefit, and dropping it reduces the code
> size.
>
> [...]
>
> before:
> text data bss dec hex filename
> 2865 252 8 3125 c35 drivers/power/supply/axp20x_usb_power.o
>
> after:
> text data bss dec hex filename
> 2822 252 0 3074 c02 drivers/power/supply/axp20x_usb_power.o

Thanks, queued.

-- Sebastian

> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/power/supply/axp20x_usb_power.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/axp20x_usb_power.c b/drivers/power/supply/axp20x_usb_power.c
> index 2397c48..44f70dc 100644
> --- a/drivers/power/supply/axp20x_usb_power.c
> +++ b/drivers/power/supply/axp20x_usb_power.c
> @@ -339,7 +339,7 @@ static int axp20x_usb_power_probe(struct platform_device *pdev)
> "VBUS_REMOVAL", "VBUS_VALID", "VBUS_NOT_VALID", NULL };
> static const char * const axp22x_irq_names[] = {
> "VBUS_PLUGIN", "VBUS_REMOVAL", NULL };
> - static const char * const *irq_names;
> + const char * const *irq_names;
> const struct power_supply_desc *usb_power_desc;
> int i, irq, ret;
>
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]