From: Lee Jones <lee.jones@linaro.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: keescook@chromium.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 9/9] mfd: max8925-i2c: Drop unnecessary static
Date: Mon, 17 Jul 2017 11:00:56 +0000 [thread overview]
Message-ID: <20170717110056.q5fp3wvjoamov5c2@dell> (raw)
In-Reply-To: <1493928654-18768-10-git-send-email-Julia.Lawall@lip6.fr>
On Thu, 04 May 2017, Julia Lawall wrote:
> Drop static on a local variable, when the variable is initialized before
> any use, on every possible execution path through the function. The static
> has no benefit, and dropping it reduces the code size.
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @bad exists@
> position p;
> identifier x;
> type T;
> @@
>
> static T x@p;
> ...
> x = <+...x...+>
>
> @@
> identifier x;
> expression e;
> type T;
> position p != bad.p;
> @@
>
> -static
> T x@p;
> ... when != x
> when strict
> ?x = e;
> // </smpl>
>
> The change in code size is indicates by the following output from the size
> command.
>
> before:
> text data bss dec hex filename
> 2579 240 16 2835 b13 drivers/mfd/max8925-i2c.o
>
> after:
> text data bss dec hex filename
> 2531 240 8 2779 adb drivers/mfd/max8925-i2c.o
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/mfd/max8925-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/max8925-i2c.c b/drivers/mfd/max8925-i2c.c
> index 5c80aea..1006323 100644
> --- a/drivers/mfd/max8925-i2c.c
> +++ b/drivers/mfd/max8925-i2c.c
> @@ -151,7 +151,7 @@ static int max8925_probe(struct i2c_client *client,
> const struct i2c_device_id *id)
> {
> struct max8925_platform_data *pdata = dev_get_platdata(&client->dev);
> - static struct max8925_chip *chip;
> + struct max8925_chip *chip;
> struct device_node *node = client->dev.of_node;
>
> if (node && !pdata) {
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-07-17 11:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 20:10 [PATCH 0/9] Drop unnecessary static Julia Lawall
2017-05-04 20:10 ` [PATCH 1/9] mtd: cfi_cmdset_0020: " Julia Lawall
2017-05-11 18:49 ` Brian Norris
2017-05-04 20:10 ` [PATCH 2/9] mtd: physmap_of: " Julia Lawall
2017-05-04 20:10 ` [PATCH 3/9] drbd: " Julia Lawall
2017-05-05 7:19 ` Roland Kammerer
2017-06-27 23:49 ` Kees Cook
2017-06-27 23:58 ` Jens Axboe
2017-05-04 20:10 ` [PATCH 4/9] power: supply: axp20x_usb_power: " Julia Lawall
2017-05-15 13:25 ` Sebastian Reichel
2017-05-04 20:10 ` [PATCH 5/9] mfd: " Julia Lawall
2017-06-27 23:46 ` Kees Cook
2017-07-03 11:42 ` Lee Jones
2017-07-17 11:01 ` Lee Jones
2017-05-04 20:10 ` [PATCH 6/9] regulator: palmas: " Julia Lawall
2017-05-14 10:13 ` Mark Brown
2017-05-15 10:41 ` Julia Lawall
2017-05-15 10:54 ` Mark Brown
2017-05-23 11:24 ` Applied "regulator: palmas: Drop unnecessary static" to the regulator tree Mark Brown
2017-05-04 20:10 ` [PATCH 7/9] iio: hid-sensor-accel-3d: Drop unnecessary static Julia Lawall
2017-05-07 12:57 ` Jonathan Cameron
2017-05-04 20:10 ` [PATCH 8/9] clocksource/drivers/fttmr010: " Julia Lawall
2017-06-27 23:45 ` Kees Cook
2017-05-04 20:10 ` [PATCH 9/9] mfd: max8925-i2c: " Julia Lawall
2017-06-27 23:47 ` Kees Cook
2017-07-03 11:42 ` Lee Jones
2017-07-17 11:00 ` Lee Jones [this message]
2017-06-27 23:47 ` [PATCH 0/9] " Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170717110056.q5fp3wvjoamov5c2@dell \
--to=lee.jones@linaro.org \
--cc=Julia.Lawall@lip6.fr \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox