kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Mark D Rustad <mrustad@gmail.com>,
	Tony Lindgren <tony@atomide.com>,
	keescook@chromium.org, kernel-janitors@vger.kernel.org,
	Lee Jones <lee.jones@linaro.org>,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/11] mfd: Drop unnecessary static
Date: Mon, 24 Jul 2017 19:20:26 +0000	[thread overview]
Message-ID: <20170724192026.GF32425@amd> (raw)
In-Reply-To: <alpine.DEB.2.20.1707152254380.5105@hadrien>

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

Hi!

> > > Drop static on a local variable, when the variable is initialized before
> > > any possible use.  Thus, the static has no benefit.

Actually... it has possible other benefit -- saving stack space. I've
used static for that purpose before. So ... careful with the
automation.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2017-07-24 19:20 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-15 20:07 [PATCH 00/11] Drop unnecessary static Julia Lawall
2017-07-15 20:07 ` [PATCH 01/11] clk: mmp: " Julia Lawall
2017-07-18  1:31   ` Stephen Boyd
2017-07-15 20:07 ` [PATCH 02/11] clk: moxart: " Julia Lawall
2017-07-18  1:31   ` Stephen Boyd
2017-07-15 20:07 ` [PATCH 03/11] mtd: physmap_of: " Julia Lawall
2017-07-17 19:58   ` Boris Brezillon
2017-08-17 12:58   ` Boris Brezillon
2017-07-15 20:07 ` [PATCH 04/11] fbdev: da8xx-fb: " Julia Lawall
2017-08-01 13:09   ` Bartlomiej Zolnierkiewicz
2017-07-15 20:07 ` [PATCH 05/11] irqchip/gic/realview: " Julia Lawall
2017-07-15 20:07 ` [PATCH 06/11] irqchip: mips-cpu: " Julia Lawall
2017-07-15 20:52   ` Mark D Rustad
2017-07-15 20:59     ` Julia Lawall
2017-07-16  6:04       ` Mark D Rustad
2017-07-15 20:07 ` [PATCH 07/11] mfd: " Julia Lawall
2017-07-15 20:49   ` Mark D Rustad
2017-07-15 20:56     ` Julia Lawall
2017-07-24 19:20       ` Pavel Machek [this message]
2017-07-24 22:27         ` Kees Cook
2017-07-25  8:00   ` Lee Jones
2017-07-15 20:07 ` [PATCH 08/11] ata: " Julia Lawall
2017-08-02  8:23   ` Linus Walleij
2017-08-02 15:12   ` Tejun Heo
2017-07-15 20:07 ` [PATCH 09/11] iio: orientation: hid-sensor-rotation: " Julia Lawall
2017-07-17 20:45   ` Jonathan Cameron
2017-07-15 20:07 ` [PATCH 10/11] irqchip: digicolor: " Julia Lawall
2017-07-16  4:49   ` Baruch Siach
2017-07-15 20:07 ` [PATCH 11/11] mfd: max8925-i2c: " Julia Lawall
2017-07-18  7:23   ` Lee Jones
2017-07-15 20:37 ` [PATCH 00/11] " Joe Perches
2017-07-15 21:00   ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170724192026.GF32425@amd \
    --to=pavel@ucw.cz \
    --cc=julia.lawall@lip6.fr \
    --cc=keescook@chromium.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mrustad@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).