From: "Serge E. Hallyn" <serge@hallyn.com>
To: linux-security-module@vger.kernel.org
Subject: Re: [PATCH 1/4] selinux: Delete eight unnecessary variable assignments
Date: Sun, 13 Aug 2017 16:24:14 +0000 [thread overview]
Message-ID: <20170813162414.GC4515@mail.hallyn.com> (raw)
In-Reply-To: <20170813162233.GB4515@mail.hallyn.com>
Quoting Serge E. Hallyn (serge@hallyn.com):
> Quoting SF Markus Elfring (elfring@users.sourceforge.net):
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Sun, 13 Aug 2017 14:17:48 +0200
> >
> > One local variable was reset to zero at the end of these functions.
> > This value will also be set by a previous call of a function if it was
> > executed successfully. Thus omit an extra assignment there.
> >
> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>
> Acked-by: Serge Hallyn <serge@hallyn.com>
BTW this does add a burden to the maintainers as it makes the
code a bit more fragile in the face of future changes. So my
ack means it looks ok, but if the maintainers don't want to take
it I absolutely understand.
next prev parent reply other threads:[~2017-08-13 16:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-13 14:43 [PATCH 0/4] SELinux: Fine-tuning for some function implementations SF Markus Elfring
2017-08-13 14:45 ` [PATCH 1/4] selinux: Delete eight unnecessary variable assignments SF Markus Elfring
2017-08-13 16:22 ` Serge E. Hallyn
2017-08-13 16:24 ` Serge E. Hallyn [this message]
2017-08-13 14:46 ` [PATCH 2/4] selinux: Adjust jump targets in ebitmap_read() SF Markus Elfring
2017-08-13 16:24 ` Serge E. Hallyn
2017-08-13 14:48 ` [PATCH 3/4] selinux: Delete an unnecessary return statement in ebitmap_destroy() SF Markus Elfring
2017-08-13 14:50 ` [PATCH 4/4] selinux: Adjust five checks for null pointers SF Markus Elfring
2017-08-13 15:41 ` Serge E. Hallyn
2017-08-14 11:00 ` Yanhao Mo
2017-08-14 20:59 ` [PATCH 0/4] SELinux: Fine-tuning for some function implementations Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170813162414.GC4515@mail.hallyn.com \
--to=serge@hallyn.com \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox