From: Colin King <colin.king@canonical.com>
To: Andreas Noever <andreas.noever@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Yehezkel Bernat <yehezkel.bernat@intel.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] thunderbolt: fix incorrect value assigned to req->response_type
Date: Tue, 15 Aug 2017 14:31:33 +0000 [thread overview]
Message-ID: <20170815143133.26500-1-colin.king@canonical.com> (raw)
From: Colin Ian King <colin.king@canonical.com>
req->response_type is being assigned the sizeof TB_CFG_PKG_RESET
and should actually be assigned TB_CFG_PKG_RESET. Fix this.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/thunderbolt/ctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c
index 69c0232a22f8..fb40dd0588b9 100644
--- a/drivers/thunderbolt/ctl.c
+++ b/drivers/thunderbolt/ctl.c
@@ -804,7 +804,7 @@ struct tb_cfg_result tb_cfg_reset(struct tb_ctl *ctl, u64 route,
req->request_type = TB_CFG_PKG_RESET;
req->response = &reply;
req->response_size = sizeof(reply);
- req->response_type = sizeof(TB_CFG_PKG_RESET);
+ req->response_type = TB_CFG_PKG_RESET;
res = tb_cfg_request_sync(ctl, req, timeout_msec);
--
2.11.0
next reply other threads:[~2017-08-15 14:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 14:31 Colin King [this message]
2017-08-15 14:38 ` [PATCH] thunderbolt: fix incorrect value assigned to req->response_type Mika Westerberg
2017-08-15 15:22 ` Dan Carpenter
2017-08-15 15:46 ` Colin Ian King
2017-08-16 8:54 ` [PATCH resend] thunderbolt: Fix reset response_type Dan Carpenter
2017-08-27 13:38 ` Mika Westerberg
2017-08-16 8:10 ` [PATCH] thunderbolt: fix incorrect value assigned to req->response_type Mika Westerberg
2017-08-16 16:13 ` Greg Kroah-Hartman
2017-08-17 9:39 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170815143133.26500-1-colin.king@canonical.com \
--to=colin.king@canonical.com \
--cc=andreas.noever@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=yehezkel.bernat@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox