From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakub Kicinski <kubakici@wp.pl>
Date: Mon, 21 Aug 2017 21:41:36 +0000
Subject: Re: [PATCH] mt7601u: check memory allocation failure
Message-Id: <20170821144136.477bf655@cakuba.netronome.com>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20170821205956.20859-1-christophe.jaillet@wanadoo.fr>
 <20170821143430.635e4b92@cakuba.netronome.com>
In-Reply-To: <20170821143430.635e4b92@cakuba.netronome.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: linux-arm-kernel@lists.infradead.org

On Mon, 21 Aug 2017 14:34:30 -0700, Jakub Kicinski wrote:
> On Mon, 21 Aug 2017 22:59:56 +0200, Christophe JAILLET wrote:
> > Check memory allocation failure and return -ENOMEM in such a case, as
> > already done a few lines below
> > 
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>  
> 
> Acked-by: Jakub Kicinski <kubakici@wp.pl>

Wait, I take that back.  This code is a bit weird.  We would return an
error, then mt7601u_dma_init() will call mt7601u_free_tx_queue() which
doesn't check for tx_q = NULL condition.

Looks like mt7601u_free_tx() has to check for dev->tx_q = NULL and
return early if that's the case.  Or mt7601u_alloc_tx() should really
clean things up on it's own on failure.  Ugh.