From mboxrd@z Thu Jan  1 00:00:00 1970
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Wed, 23 Aug 2017 23:22:54 +0000
Subject: Re: [PATCH] staging: lustre: obd: check for allocation failure
Message-Id: <20170823232254.GA6868@kroah.com>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20170823064917.afedqlponb5qu6og@mwanda>
In-Reply-To: <20170823064917.afedqlponb5qu6og@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: lustre-devel@lists.lustre.org

On Wed, Aug 23, 2017 at 09:51:31AM +0300, Dan Carpenter wrote:
> lustre_cfg_new() can fail with ERR_PTR(-ENOMEM) so we should check for
> that.
> 
> Fixes: d7e09d0397e8 ("staging: add Lustre file system client support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/staging/lustre/lustre/obdclass/obd_mount.c b/drivers/staging/lustre/lustre/obdclass/obd_mount.c
> index 8e0d4b1d86dc..7cb99f11caa0 100644
> --- a/drivers/staging/lustre/lustre/obdclass/obd_mount.c
> +++ b/drivers/staging/lustre/lustre/obdclass/obd_mount.c
> @@ -159,6 +159,8 @@ static int do_lcfg(char *cfgname, lnet_nid_t nid, int cmd,
>  		lustre_cfg_bufs_set_string(&bufs, 4, s4);
>  
>  	lcfg = lustre_cfg_new(cmd, &bufs);
> +	if (IS_ERR(lcfg))
> +		return PTR_ERR(lcfg);
>  	lcfg->lcfg_nid = nid;
>  	rc = class_process_config(lcfg);
>  	lustre_cfg_free(lcfg);

Doesn't apply to my tree anymore :(