From: Theodore Ts'o <tytso@mit.edu>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Eric Sandeen <esandeen@redhat.com>,
linux-ext4@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: ext4: Delete an error message for a failed memory allocation in ext4_multi_mount_protect()
Date: Thu, 24 Aug 2017 17:44:45 +0000 [thread overview]
Message-ID: <20170824174445.gfrkr35m4vcfuoat@thunk.org> (raw)
In-Reply-To: <e522d9a5-4d5a-b4a1-fe94-bb3aae4c5976@users.sourceforge.net>
On Sat, Aug 19, 2017 at 08:00:31PM +0200, SF Markus Elfring wrote:
> >> Omit an extra message for a memory allocation failure in this function.
> >
> > I might be dense, but what makes this message "extra?"
> >
> > (I suppose kmalloc squawks too if it fails,
>
> Do you find the default allocation failure report sufficient?
From a helpdesk reporting situation, having a more specific message
when there is a MMP failure causing the mount to fail is definitely
useful.
So, NACK.
- Ted
next prev parent reply other threads:[~2017-08-24 17:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-19 11:46 [PATCH 0/2] fs-ext4: Adjustments for two function implementations SF Markus Elfring
2017-08-19 11:47 ` [PATCH 1/2] ext4: Delete an error message for a failed memory allocation in ext4_multi_mount_protect SF Markus Elfring
2017-08-19 17:08 ` [PATCH 1/2] ext4: Delete an error message for a failed memory allocation in ext4_multi_mount_pro Eric Sandeen
2017-08-19 18:00 ` ext4: Delete an error message for a failed memory allocation in ext4_multi_mount_protect() SF Markus Elfring
2017-08-24 17:44 ` Theodore Ts'o [this message]
2017-08-24 19:16 ` [PATCH 1/2] ext4: Delete an error message for a failed memory allocation in ext4_multi_mount_pro Dan Carpenter
2017-08-19 11:48 ` [PATCH 2/2] ext4: Improve a size determination in two functions SF Markus Elfring
2017-08-20 1:49 ` Eric Sandeen
2017-08-24 17:50 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824174445.gfrkr35m4vcfuoat@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=elfring@users.sourceforge.net \
--cc=esandeen@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox