Re: [PATCH] thunderbolt: fix incorrect value assigned to req->response_type

Dan Carpenter
2017-08-15T15:22:59Z

On Tue, Aug 15, 2017 at 05:38:34PM +0300, Mika Westerberg wrote:
> On Tue, Aug 15, 2017 at 03:31:33PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > req->response_type is being assigned the sizeof TB_CFG_PKG_RESET
> > and should actually be assigned TB_CFG_PKG_RESET. Fix this.
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> IIRC I already acked this some time ago ;-)
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> BTW, you should CC Greg as he has been gathering Thunderbolt related
> patches. I added him now.

Yeah. I sent this patch on Jun 14. "[PATCH] thunderbolt: Fix reset
response_type" I didn't CC Greg, either. Someone should probably
update MAINTAINERS if Greg needs to get these emails.

Colin, could you please add Fixes tags to your patches? It helps me
investigate how bugs are introduced. I know we all had a long thread
and agreed to not add them if the patch probably doesn't fix a user
visible bug, but this one is clearly a bugfix.

regards,
dan carpenter