Re: [PATCH] thunderbolt: fix incorrect value assigned to req->response_type

Mika Westerberg
2017-08-17T09:39:28Z

On Wed, Aug 16, 2017 at 09:13:27AM -0700, Greg Kroah-Hartman wrote:
> On Wed, Aug 16, 2017 at 11:10:01AM +0300, Mika Westerberg wrote:
> > On Tue, Aug 15, 2017 at 06:22:59PM +0300, Dan Carpenter wrote:
> > > On Tue, Aug 15, 2017 at 05:38:34PM +0300, Mika Westerberg wrote:
> > > > On Tue, Aug 15, 2017 at 03:31:33PM +0100, Colin King wrote:
> > > > > From: Colin Ian King <colin.king@canonical.com>
> > > > >
> > > > > req->response_type is being assigned the sizeof TB_CFG_PKG_RESET
> > > > > and should actually be assigned TB_CFG_PKG_RESET. Fix this.
> > > > >
> > > > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > > >
> > > > IIRC I already acked this some time ago ;-)
> > > >
> > > > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > > >
> > > > BTW, you should CC Greg as he has been gathering Thunderbolt related
> > > > patches. I added him now.
> > >
> > > Yeah. I sent this patch on Jun 14. "[PATCH] thunderbolt: Fix reset
> > > response_type" I didn't CC Greg, either. Someone should probably
> > > update MAINTAINERS if Greg needs to get these emails.
> >
> > Indeed.
> >
> > Greg, Andreas,
> >
> > Should we add Greg to the MAINTAINERS so that he will be getting all the
> > thunderbolt related patches? Another way, if we want to make this easier
> > for Greg, is to establish a thunderbolt tree in kernel.org and send pull
> > requests to him directly.
>
> The "maintainers" of thunderbolt should either be forwarding on patches
> to me to accept, or to give me a git tree to pull, or to ack patches
> that I am cc:ed on. Whichever works best for them, but in all cases, I
> am not the maintainer of the thunderbolt subsystem, so I don't need to
> be listed under MAINTAINERS.

OK, thanks for the clarification :)