* [PATCH][staging-next] staging: typec: tcpm: make function tcpm_get_pwr_opmode
@ 2017-08-22 16:02 Colin King
2017-08-27 16:45 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-08-22 16:02 UTC (permalink / raw)
To: Greg Kroah-Hartman, Guenter Roeck, Badhri Jagan Sridharan,
Thomas Gardner, devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function pointer tcpm_get_pwr_opmode is local to the source and does
not need to be in global scope, so make it static.
Cleans up sparse warning:
symbol 'tcpm_get_pwr_opmode' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/staging/typec/tcpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c
index 7b5ba27dd935..a911cad41a59 100644
--- a/drivers/staging/typec/tcpm.c
+++ b/drivers/staging/typec/tcpm.c
@@ -2131,7 +2131,7 @@ static void tcpm_swap_complete(struct tcpm_port *port, int result)
}
}
-enum typec_pwr_opmode tcpm_get_pwr_opmode(enum typec_cc_status cc)
+static enum typec_pwr_opmode tcpm_get_pwr_opmode(enum typec_cc_status cc)
{
switch (cc) {
case TYPEC_CC_RP_1_5:
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][staging-next] staging: typec: tcpm: make function tcpm_get_pwr_opmode
2017-08-22 16:02 [PATCH][staging-next] staging: typec: tcpm: make function tcpm_get_pwr_opmode Colin King
@ 2017-08-27 16:45 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2017-08-27 16:45 UTC (permalink / raw)
To: Colin King
Cc: Greg Kroah-Hartman, Badhri Jagan Sridharan, Thomas Gardner, devel,
kernel-janitors, linux-kernel
On Tue, Aug 22, 2017 at 05:02:18PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function pointer tcpm_get_pwr_opmode is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'tcpm_get_pwr_opmode' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/staging/typec/tcpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c
> index 7b5ba27dd935..a911cad41a59 100644
> --- a/drivers/staging/typec/tcpm.c
> +++ b/drivers/staging/typec/tcpm.c
> @@ -2131,7 +2131,7 @@ static void tcpm_swap_complete(struct tcpm_port *port, int result)
> }
> }
>
> -enum typec_pwr_opmode tcpm_get_pwr_opmode(enum typec_cc_status cc)
> +static enum typec_pwr_opmode tcpm_get_pwr_opmode(enum typec_cc_status cc)
> {
> switch (cc) {
> case TYPEC_CC_RP_1_5:
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-27 16:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-22 16:02 [PATCH][staging-next] staging: typec: tcpm: make function tcpm_get_pwr_opmode Colin King
2017-08-27 16:45 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox