From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Sun, 27 Aug 2017 16:45:14 +0000 Subject: Re: [PATCH][staging-next] staging: typec: tcpm: make function tcpm_get_pwr_opmode Message-Id: <20170827164514.GC22819@roeck-us.net> List-Id: References: <20170822160218.32316-1-colin.king@canonical.com> In-Reply-To: <20170822160218.32316-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Greg Kroah-Hartman , Badhri Jagan Sridharan , Thomas Gardner , devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, Aug 22, 2017 at 05:02:18PM +0100, Colin King wrote: > From: Colin Ian King > > The function pointer tcpm_get_pwr_opmode is local to the source and does > not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'tcpm_get_pwr_opmode' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Reviewed-by: Guenter Roeck > --- > drivers/staging/typec/tcpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c > index 7b5ba27dd935..a911cad41a59 100644 > --- a/drivers/staging/typec/tcpm.c > +++ b/drivers/staging/typec/tcpm.c > @@ -2131,7 +2131,7 @@ static void tcpm_swap_complete(struct tcpm_port *port, int result) > } > } > > -enum typec_pwr_opmode tcpm_get_pwr_opmode(enum typec_cc_status cc) > +static enum typec_pwr_opmode tcpm_get_pwr_opmode(enum typec_cc_status cc) > { > switch (cc) { > case TYPEC_CC_RP_1_5: > -- > 2.14.1 >