From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Thu, 31 Aug 2017 16:52:47 +0000 Subject: Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL Message-Id: <20170831165247.GA26219@kroah.com> List-Id: References: <20170830140456.7n6sfogqb7mvjmrm@mwanda> In-Reply-To: <20170830140456.7n6sfogqb7mvjmrm@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Shaohua Li , linux-block@vger.kernel.org, Jens Axboe , Tejun Heo , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Wed, Aug 30, 2017 at 05:04:56PM +0300, Dan Carpenter wrote: > The kernfs_get_inode() returns NULL on error, it never returns error > pointers. > > Fixes: aa8188253474 ("kernfs: add exportfs operations") > Signed-off-by: Dan Carpenter > Acked-by: Tejun Heo Hm, I don't know what tree aa8188253474 is in, but it's not mine, so I can't take this patch :( thanks, greg k-h