From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: devel@driverdev.osuosl.org, Lars-Peter Clausen <lars@metafoo.de>,
Eva Rachel Retuya <eraretuya@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel-janitors@vger.kernel.org, linux-iio@vger.kernel.org,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Hartmut Knaack <knaack.h@gmx.de>,
simran singhal <singhalsimran0@gmail.com>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v2] staging: iio: tsl2x7x: clean up limit checks
Date: Fri, 08 Sep 2017 14:05:59 +0000 [thread overview]
Message-ID: <20170908140559.7afomklpxogwnlgt@mwanda> (raw)
In-Reply-To: <59B29FCA.6070001@bfs.de>
On Fri, Sep 08, 2017 at 03:48:58PM +0200, walter harms wrote:
> > - while (i < (TSL2X7X_MAX_LUX_TABLE_SIZE * 3)) {
> > + while (i < TSL2X7X_MAX_LUX_TABLE_SIZE) {
> > offset += snprintf(buf + offset, PAGE_SIZE, "%u,%u,%u,",
> > chip->tsl2x7x_device_lux[i].ratio,
> > chip->tsl2x7x_device_lux[i].ch0,
>
> Is that TSL2X7X_MAX_LUX_TABLE_SIZE needed at all ?
Nope. Not needed but not harmful. Adding redundant limit checks is
pretty normal so it's fine. I'm not going to remove it.
regards,
dan carpenter
next prev parent reply other threads:[~2017-09-08 14:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 10:11 [PATCH] iio staging: tsl2x7x: clean up limit checks Dan Carpenter
2017-09-03 11:35 ` Jonathan Cameron
2017-09-04 2:12 ` Brian Masney
2017-09-05 14:58 ` Dan Carpenter
2017-09-05 21:02 ` Brian Masney
2017-09-05 23:31 ` Brian Masney
2017-09-06 12:41 ` Dan Carpenter
2017-09-08 10:53 ` [PATCH v2] staging: iio: " Dan Carpenter
2017-09-08 13:48 ` walter harms
2017-09-08 14:05 ` Dan Carpenter [this message]
2017-09-15 23:30 ` Brian Masney
2017-09-16 11:11 ` Paolo Cretaro
2017-09-16 11:37 ` Dan Carpenter
2017-09-16 12:18 ` Paolo Cretaro
2017-09-16 22:05 ` Jonathan Cameron
2017-09-18 9:58 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908140559.7afomklpxogwnlgt@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=eraretuya@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=singhalsimran0@gmail.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox