public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-media@vger.kernel.org,
	Arvind Yadav <arvind.yadav.cs@gmail.com>,
	Bhumika Goyal <bhumirks@gmail.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Mike Isely <isely@pobox.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/5] [media] s2255drv: Adjust 13 checks for null pointers
Date: Wed, 20 Sep 2017 23:07:30 +0000	[thread overview]
Message-ID: <20170920230729.b2jujsdcjtvjrjun@mwanda> (raw)
In-Reply-To: <66f0b95e-e717-7a50-39d2-05fcbf7b77bd@users.sourceforge.net>

On Wed, Sep 20, 2017 at 06:58:56PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 20 Sep 2017 16:46:19 +0200
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 

You've been told several times that this stuff doesn't work.  Try
applying this patch with `git am` and you'll see why.

regards,
dan carpenter


  reply	other threads:[~2017-09-20 23:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-20 16:55 [PATCH 0/5] [media] s2255drv: Fine-tuning for some function implementations SF Markus Elfring
2017-09-20 16:57 ` [PATCH 1/5] [media] s2255drv: Delete three error messages for a failed memory allocation in s2255_pr SF Markus Elfring
2017-09-20 16:58 ` [PATCH 2/5] [media] s2255drv: Adjust 13 checks for null pointers SF Markus Elfring
2017-09-20 23:07   ` Dan Carpenter [this message]
2017-09-21  8:12     ` SF Markus Elfring
2017-09-21  9:22       ` Dan Carpenter
2017-09-21 11:23         ` SF Markus Elfring
2017-09-20 17:00 ` [PATCH 3/5] [media] s2255drv: Improve two size determinations in s2255_probe() SF Markus Elfring
2017-09-20 17:01 ` [PATCH 4/5] [media] s2255drv: Use common error handling code in read_pipe_completion() SF Markus Elfring
2017-09-20 17:02 ` [PATCH 5/5] [media] s2255drv: Delete an unnecessary return statement in five functions SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170920230729.b2jujsdcjtvjrjun@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=bhumirks@gmail.com \
    --cc=elfring@users.sourceforge.net \
    --cc=isely@pobox.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox