From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Hart Date: Mon, 09 Oct 2017 18:29:00 +0000 Subject: Re: [PATCH] platform/x86: mlx-platform: make a couple of structures static Message-Id: <20171009182900.GH12321@fury> List-Id: References: <20171005104211.30440-1-colin.king@canonical.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andy Shevchenko Cc: Colin King , Vadim Pasternak , Andy Shevchenko , Platform Driver , kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" On Sat, Oct 07, 2017 at 05:03:41PM +0300, Andy Shevchenko wrote: > On Thu, Oct 5, 2017 at 1:42 PM, Colin King wrote: > > From: Colin Ian King > > > > The structures mlxplat_dev and mlxplat_hotplug are local to the source > > and do not need to be in global scope, so make them static. > > > > Cleans up sparse warnings: > > symbol 'mlxplat_dev' was not declared. Should it be static? > > symbol 'mlxplat_hotplug' was not declared. Should it be static? > > Thanks for the patch. > Since Vadim did some rather big driver changes I would like to hear > from him how to proceed with this one: either I apply it now, or after > we get Vadim's series in. I'll be working with Vadim's series shortly and would like to take this after that is settled. -- Darren Hart VMware Open Source Technology Center