Re: [PATCH 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init()

Laurent Pinchart
2017-10-29T17:12:16Z

Hi Jani,

On Friday, 27 October 2017 21:45:17 EET Jani Nikula wrote:
> On Tue, 24 Oct 2017, SF Markus Elfring wrote:
> > Add a jump target so that a bit of exception handling can be better reused
> > at the end of this function.
> >
> > This issue was detected by using the Coccinelle software.
>
> Please also look into the GCC software, which will detect that your
> patch does not compile.

Just for the record, I've been bitten in the past by applying one of Markus'
patches that seemed to make sense, only to discover later that it introduced a
security hole. I now drop his patches altogether, so could you please keep an
eye open to make sure none of them touching the rcar-du driver will be applied
through drm-misc ?

--
Regards,

Laurent Pinchart