Re: [PATCH 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init()

kbuild test robot
2017-10-26T12:40:24Z

[-- Attachment #1: Type: text/plain, Size: 3025 bytes --]

Hi Markus,

[auto build test ERROR on drm/drm-next]
[also build test ERROR on v4.14-rc6 next-20171018]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/SF-Markus-Elfring/R-Car-Display-Unit-Fine-tuning-for-some-function-implementations/20171026-160928
base: git://people.freedesktop.org/~airlied/linux.git drm-next
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm64

All error/warnings (new ones prefixed by >>):

drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_encoders_init':
>> drivers/gpu/drm/rcar-du/rcar_du_kms.c:415:9: error: 'ret' undeclared (first use in this function)
return ret;
^~~
drivers/gpu/drm/rcar-du/rcar_du_kms.c:415:9: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/gpu/drm/rcar-du/rcar_du_kms.c:416:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^

vim +/ret +415 drivers/gpu/drm/rcar-du/rcar_du_kms.c

362
363 static int rcar_du_encoders_init(struct rcar_du_device *rcdu)
364 {
365 struct device_node *np = rcdu->dev->of_node;
366 struct device_node *ep_node;
367 unsigned int num_encoders = 0;
368
369 /*
370 * Iterate over the endpoints and create one encoder for each output
371 * pipeline.
372 */
373 for_each_endpoint_of_node(np, ep_node) {
374 enum rcar_du_output output;
375 struct of_endpoint ep;
376 unsigned int i;
377 int ret;
378
379 ret = of_graph_parse_endpoint(ep_node, &ep);
380 if (ret < 0)
381 goto put_node;
382
383 /* Find the output route corresponding to the port number. */
384 for (i = 0; i < RCAR_DU_OUTPUT_MAX; ++i) {
385 if (rcdu->info->routes[i].possible_crtcs &&
386 rcdu->info->routes[i].port == ep.port) {
387 output = i;
388 break;
389 }
390 }
391
392 if (i == RCAR_DU_OUTPUT_MAX) {
393 dev_warn(rcdu->dev,
394 "port %u references unexisting output, skipping\n",
395 ep.port);
396 continue;
397 }
398
399 /* Process the output pipeline. */
400 ret = rcar_du_encoders_init_one(rcdu, output, &ep);
401 if (ret < 0) {
402 if (ret == -EPROBE_DEFER)
403 goto put_node;
404
405 continue;
406 }
407
408 num_encoders++;
409 }
410
411 return num_encoders;
412
413 put_node:
414 of_node_put(ep_node);
> 415 return ret;
> 416 }
417

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36854 bytes --]