Re: [PATCH] iio/adc/palmas: Use common error handling code in palmas_gpadc_calibrate()

SF Markus Elfring
2017-10-27T13:43:27Z

>> @@ -329,6 +325,10 @@ static int palmas_gpadc_calibrate(struct palmas_gpadc *adc, int adc_chan)
>>
>> scrub:
>> return ret;
>> +
>> +report_failure:
>
> This makes for complex code flow where it is not needed.

The shown code layout would be required in the suggested software design direction.

> As such I am not going to even think about taking this sort of patch.

It might take more time until similar situations will be reconsidered.

>> + dev_err(adc->dev, "TRIM read failed: %d\n", ret);
>> + goto scrub;
>> }
>>
>> static int palmas_gpadc_start_conversion(struct palmas_gpadc *adc, int adc_chan)

Do any other contributors find a bit of code reduction desirable for this
software module?

Regards,
Markus