* [PATCH] omapdrm: hdmi4_cec: signedness bug in hdmi4_cec_init()
@ 2017-10-27 6:27 Dan Carpenter
2017-10-27 18:51 ` Sebastian Reichel
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-10-27 6:27 UTC (permalink / raw)
To: Tomi Valkeinen, Hans Verkuil; +Cc: David Airlie, dri-devel, kernel-janitors
"ret" needs to be signed for the error handling to work.
Fixes: 8d7f934df8d8 ("omapdrm: hdmi4_cec: add OMAP4 HDMI CEC support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c b/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c
index d86873f2abe6..e626eddf24d5 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c
@@ -352,7 +352,7 @@ int hdmi4_cec_init(struct platform_device *pdev, struct hdmi_core_data *core,
{
const u32 caps = CEC_CAP_TRANSMIT | CEC_CAP_LOG_ADDRS |
CEC_CAP_PASSTHROUGH | CEC_CAP_RC;
- unsigned int ret;
+ int ret;
core->adap = cec_allocate_adapter(&hdmi_cec_adap_ops, core,
"omap4", caps, CEC_MAX_LOG_ADDRS);
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] omapdrm: hdmi4_cec: signedness bug in hdmi4_cec_init()
2017-10-27 6:27 [PATCH] omapdrm: hdmi4_cec: signedness bug in hdmi4_cec_init() Dan Carpenter
@ 2017-10-27 18:51 ` Sebastian Reichel
2017-10-28 9:16 ` Hans Verkuil
2017-11-21 10:30 ` Tomi Valkeinen
2 siblings, 0 replies; 4+ messages in thread
From: Sebastian Reichel @ 2017-10-27 18:51 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Tomi Valkeinen, Hans Verkuil, kernel-janitors, dri-devel
[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]
Hi,
On Fri, Oct 27, 2017 at 09:27:05AM +0300, Dan Carpenter wrote:
> "ret" needs to be signed for the error handling to work.
>
> Fixes: 8d7f934df8d8 ("omapdrm: hdmi4_cec: add OMAP4 HDMI CEC support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
-- Sebastian
> diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c b/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c
> index d86873f2abe6..e626eddf24d5 100644
> --- a/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c
> +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c
> @@ -352,7 +352,7 @@ int hdmi4_cec_init(struct platform_device *pdev, struct hdmi_core_data *core,
> {
> const u32 caps = CEC_CAP_TRANSMIT | CEC_CAP_LOG_ADDRS |
> CEC_CAP_PASSTHROUGH | CEC_CAP_RC;
> - unsigned int ret;
> + int ret;
>
> core->adap = cec_allocate_adapter(&hdmi_cec_adap_ops, core,
> "omap4", caps, CEC_MAX_LOG_ADDRS);
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] omapdrm: hdmi4_cec: signedness bug in hdmi4_cec_init()
2017-10-27 6:27 [PATCH] omapdrm: hdmi4_cec: signedness bug in hdmi4_cec_init() Dan Carpenter
2017-10-27 18:51 ` Sebastian Reichel
@ 2017-10-28 9:16 ` Hans Verkuil
2017-11-21 10:30 ` Tomi Valkeinen
2 siblings, 0 replies; 4+ messages in thread
From: Hans Verkuil @ 2017-10-28 9:16 UTC (permalink / raw)
To: Dan Carpenter, Tomi Valkeinen, Hans Verkuil; +Cc: kernel-janitors, dri-devel
On 10/27/2017 08:27 AM, Dan Carpenter wrote:
> "ret" needs to be signed for the error handling to work.
>
> Fixes: 8d7f934df8d8 ("omapdrm: hdmi4_cec: add OMAP4 HDMI CEC support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Oops! Not sure how that crept in.
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Thanks!
Hans
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c b/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c
> index d86873f2abe6..e626eddf24d5 100644
> --- a/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c
> +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c
> @@ -352,7 +352,7 @@ int hdmi4_cec_init(struct platform_device *pdev, struct hdmi_core_data *core,
> {
> const u32 caps = CEC_CAP_TRANSMIT | CEC_CAP_LOG_ADDRS |
> CEC_CAP_PASSTHROUGH | CEC_CAP_RC;
> - unsigned int ret;
> + int ret;
>
> core->adap = cec_allocate_adapter(&hdmi_cec_adap_ops, core,
> "omap4", caps, CEC_MAX_LOG_ADDRS);
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] omapdrm: hdmi4_cec: signedness bug in hdmi4_cec_init()
2017-10-27 6:27 [PATCH] omapdrm: hdmi4_cec: signedness bug in hdmi4_cec_init() Dan Carpenter
2017-10-27 18:51 ` Sebastian Reichel
2017-10-28 9:16 ` Hans Verkuil
@ 2017-11-21 10:30 ` Tomi Valkeinen
2 siblings, 0 replies; 4+ messages in thread
From: Tomi Valkeinen @ 2017-11-21 10:30 UTC (permalink / raw)
To: Dan Carpenter, Hans Verkuil; +Cc: David Airlie, kernel-janitors, dri-devel
On 27/10/17 09:27, Dan Carpenter wrote:
> "ret" needs to be signed for the error handling to work.
>
> Fixes: 8d7f934df8d8 ("omapdrm: hdmi4_cec: add OMAP4 HDMI CEC support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c b/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c
> index d86873f2abe6..e626eddf24d5 100644
> --- a/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c
> +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c
> @@ -352,7 +352,7 @@ int hdmi4_cec_init(struct platform_device *pdev, struct hdmi_core_data *core,
> {
> const u32 caps = CEC_CAP_TRANSMIT | CEC_CAP_LOG_ADDRS |
> CEC_CAP_PASSTHROUGH | CEC_CAP_RC;
> - unsigned int ret;
> + int ret;
>
> core->adap = cec_allocate_adapter(&hdmi_cec_adap_ops, core,
> "omap4", caps, CEC_MAX_LOG_ADDRS);
>
Thanks. I have picked this up.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-21 10:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-27 6:27 [PATCH] omapdrm: hdmi4_cec: signedness bug in hdmi4_cec_init() Dan Carpenter
2017-10-27 18:51 ` Sebastian Reichel
2017-10-28 9:16 ` Hans Verkuil
2017-11-21 10:30 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox