Re: [PATCH] omapdrm: hdmi4_cec: signedness bug in hdmi4_cec_init()

Tomi Valkeinen
2017-11-21T10:30:24Z

On 27/10/17 09:27, Dan Carpenter wrote:
> "ret" needs to be signed for the error handling to work.
>
> Fixes: 8d7f934df8d8 ("omapdrm: hdmi4_cec: add OMAP4 HDMI CEC support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c b/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c
> index d86873f2abe6..e626eddf24d5 100644
> --- a/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c
> +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c
> @@ -352,7 +352,7 @@ int hdmi4_cec_init(struct platform_device *pdev, struct hdmi_core_data *core,
> {
> const u32 caps = CEC_CAP_TRANSMIT | CEC_CAP_LOG_ADDRS |
> CEC_CAP_PASSTHROUGH | CEC_CAP_RC;
> - unsigned int ret;
> + int ret;
>
> core->adap = cec_allocate_adapter(&hdmi_cec_adap_ops, core,
> "omap4", caps, CEC_MAX_LOG_ADDRS);
>

Thanks. I have picked this up.

Tomi

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki