From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Fri, 27 Oct 2017 12:16:43 +0000 Subject: Re: [PATCH] usb: max3421: unlock on error in max3421_hub_control() Message-Id: <20171027121643.2ep2fryouzkrffjl@mwanda> List-Id: References: <20171027062620.emm5wwdv73kjjpvl@mwanda> In-Reply-To: <20171027062620.emm5wwdv73kjjpvl@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org On Fri, Oct 27, 2017 at 02:08:38PM +0200, Jules Maselbas wrote: > > > On Fri, Oct 27, 2017 at 11:06:36AM +0200, Jules Maselbas wrote: > >> Hi, > >> > >> > We can't return directly in max3421_hub_control(), we have to unlock > >> > first. > >> Yes you are right. > >> I think testing if pdata is null is not necessary as driver_probe will fail if > >> the device do not have a platform_data. > >> > > > > In that case, let's drop my patch. Could you send a patch for which > > removes the NULL check and add a Reported-by: for me? > It is already in the v2 (and v3) of my initial patch. > https://www.spinics.net/lists/devicetree/msg199901.html > > Should I make a brand new patch (not another version)? Yeah. Greg never rebases once the tree has been shared with the public so you'll need to send a new patch instead of a v3. regards, dan carpenter