From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Date: Mon, 30 Oct 2017 08:28:58 +0000 Subject: Re: [PATCH] ubi: fastmap: clean up the initialization of pointer p Message-Id: <20171030092858.11100194@bbrezillon> List-Id: References: <20171029131426.6205-1-colin.king@canonical.com> In-Reply-To: <20171029131426.6205-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Artem Bityutskiy , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Sun, 29 Oct 2017 13:14:26 +0000 Colin King wrote: > From: Colin Ian King > > The pointer p is being initialized with one value and a few lines > later being set to a newer replacement value. Clean up the code by > using the latter assignment to p as the initial value. Cleans up > clang warning: > > drivers/mtd/ubi/fastmap.c:217:19: warning: Value stored to 'p' > during its initialization is never read > > Signed-off-by: Colin Ian King Reviewed-by: Boris Brezillon > --- > drivers/mtd/ubi/fastmap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c > index 5a832bc79b1b..9be4b94e83ad 100644 > --- a/drivers/mtd/ubi/fastmap.c > +++ b/drivers/mtd/ubi/fastmap.c > @@ -214,9 +214,8 @@ static void assign_aeb_to_av(struct ubi_attach_info *ai, > struct ubi_ainf_volume *av) > { > struct ubi_ainf_peb *tmp_aeb; > - struct rb_node **p = &ai->volumes.rb_node, *parent = NULL; > + struct rb_node **p = &av->root.rb_node, *parent = NULL; > > - p = &av->root.rb_node; > while (*p) { > parent = *p; >