public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: rodrigosiqueira <rodrigosiqueiramelo@gmail.com>
To: peterz@infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Scheduler: Removed first parameter from prepare_lock_switch
Date: Tue, 05 Dec 2017 14:02:00 +0000	[thread overview]
Message-ID: <20171205140200.4guikhmagltvoehm@smtp.gmail.com> (raw)

The first parameter of prepare_lock_switch (kernel/sched/sched.h) is not
used anymore. Commit c55f5158f removed the code that use the first
parameter and function prepare_lock_switch is only used in
prepare_task_switch (kernel/sched/core.c)

I tested it in a virtual machine running Debian x86_64 with kvm. I
also tested it in my computer which is a x86_64 machine running Arch Linux
and everything is fine.

Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
---
 kernel/sched/core.c  | 2 +-
 kernel/sched/sched.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index c85dfb746f8c..0b1781cfa0ca 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -2592,7 +2592,7 @@ prepare_task_switch(struct rq *rq, struct task_struct *prev,
 	sched_info_switch(rq, prev, next);
 	perf_event_task_sched_out(prev, next);
 	fire_sched_out_preempt_notifiers(prev, next);
-	prepare_lock_switch(rq, next);
+	prepare_lock_switch(next);
 	prepare_arch_switch(next);
 }
 
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index b19552a212de..089953e4ec66 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -1328,7 +1328,7 @@ static inline int task_on_rq_migrating(struct task_struct *p)
 # define finish_arch_post_lock_switch()	do { } while (0)
 #endif
 
-static inline void prepare_lock_switch(struct rq *rq, struct task_struct *next)
+static inline void prepare_lock_switch(struct task_struct *next)
 {
 #ifdef CONFIG_SMP
 	/*
-- 
2.15.1


             reply	other threads:[~2017-12-05 14:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 14:02 rodrigosiqueira [this message]
2017-12-06 12:14 ` [PATCH] Scheduler: Removed first parameter from prepare_lock_switch Peter Zijlstra
2017-12-06 23:50   ` Rodrigo Siqueira
2017-12-07  8:38     ` Peter Zijlstra
2017-12-07 21:52       ` Rodrigo Siqueira
2017-12-10 21:25         ` Rodrigo Siqueira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171205140200.4guikhmagltvoehm@smtp.gmail.com \
    --to=rodrigosiqueiramelo@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox