From: Darren Hart <dvhart@infradead.org>
To: Joe Perches <joe@perches.com>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Andy Shevchenko <andy@infradead.org>,
Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: platform/x86/thinkpad_acpi: Adjustments for four function implementations
Date: Wed, 03 Jan 2018 01:13:52 +0000 [thread overview]
Message-ID: <20180103011352.GE24794@fury> (raw)
In-Reply-To: <1514940583.31497.4.camel@perches.com>
On Tue, Jan 02, 2018 at 04:49:43PM -0800, Joe Perches wrote:
> On Tue, 2018-01-02 at 16:10 -0800, Darren Hart wrote:
> > > > Leave those pr_ messages alone, please,
> []
> > Andy and Henrique raised a few reasons why these patches should not be
> > accepted:
> >
> > 1. This is init code (so any space savings is short lived)
>
> Not exactly true.
>
> The object code itself is short lived, but the
> string constant of the format is not as it is
> placed in const and not discarded.
Thanks for the clarification, appreciate it. I hadn't looked into it in enough
detail previously.
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2018-01-03 1:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 21:26 [PATCH 0/2] platform/x86/thinkpad_acpi: Adjustments for four function implementations SF Markus Elfring
2017-12-18 21:28 ` [PATCH 1/2] platform/x86/thinkpad_acpi: Delete an error message for a failed memory allocation in th SF Markus Elfring
2017-12-18 21:30 ` [PATCH 2/2] platform/x86/thinkpad_acpi: Improve a size determination in tpacpi_new_rfkill() SF Markus Elfring
2017-12-19 14:37 ` [PATCH 0/2] platform/x86/thinkpad_acpi: Adjustments for four function implementations Andy Shevchenko
2017-12-19 16:23 ` SF Markus Elfring
2017-12-19 17:28 ` Andy Shevchenko
2017-12-23 1:40 ` Henrique de Moraes Holschuh
2017-12-23 7:12 ` SF Markus Elfring
2018-01-03 0:10 ` Darren Hart
2018-01-03 0:49 ` Joe Perches
2018-01-03 1:13 ` Darren Hart [this message]
2018-01-03 8:41 ` SF Markus Elfring
2018-01-06 1:26 ` Darren Hart
2018-01-06 8:55 ` SF Markus Elfring
2017-12-23 1:29 ` [PATCH 0/2] " Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103011352.GE24794@fury \
--to=dvhart@infradead.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=elfring@users.sourceforge.net \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox