From: Jason Gunthorpe <jgg@ziepe.ca>
To: Tariq Toukan <tariqt@mellanox.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
SF Markus Elfring <elfring@users.sourceforge.net>,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ethernet: mlx4: Delete an error message for a failed memory allocation in five functions
Date: Wed, 03 Jan 2018 16:03:16 +0000 [thread overview]
Message-ID: <20180103160316.GB11348@ziepe.ca> (raw)
In-Reply-To: <adfc3229-d3f9-afb9-00e6-9f765af0cbe8@mellanox.com>
On Wed, Jan 03, 2018 at 01:24:59PM +0200, Tariq Toukan wrote:
> >Strings take up space. Since there is a backtrace on an out of memory
> >problem, if the string does not provide any more information than the
> >position of the call, then there is not much added value. I don't know
> >what was the string in this case. If it provides some additional
> >information, then it would be reasonable to keep it.
>
> I don't really accept this claim...
The standard we are moving to is to rely on the backtrace print for
debugging. It is so huge it is unlikely a single print from the driver
will make much difference to the user's view.
Most users think backtrace = oops = bug report.
> In addition, some out-of-memory errors are recoverable, even though their
> backtrace is also printed. For example, in function mlx4_en_create_cq
> (appears in patch) we have a first allocation attempt (kzalloc_node) and a
> fallback (kzalloc).
Please send a patch fixing this as other have suggested, it is clearly
a bug.
Jason
next prev parent reply other threads:[~2018-01-03 16:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-01 20:46 [PATCH] ethernet: mlx4: Delete an error message for a failed memory allocation in five functions SF Markus Elfring
2018-01-03 7:58 ` Tariq Toukan
2018-01-03 8:06 ` Julia Lawall
2018-01-03 11:24 ` Tariq Toukan
2018-01-03 14:17 ` Leon Romanovsky
2018-01-03 14:22 ` SF Markus Elfring
2018-01-04 9:24 ` Tariq Toukan
2018-01-03 16:03 ` Jason Gunthorpe [this message]
[not found] ` <30191db0-4d99-0349-b66a-c7354ef90d50-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2018-01-04 9:28 ` [PATCH] " Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103160316.GB11348@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=elfring@users.sourceforge.net \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox