From: Dan Carpenter <dan.carpenter@oracle.com>
To: Manuel Lauss <manuel.lauss@gmail.com>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Manuel Lauss <manuel.lauss@googlemail.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] ASoC: au1x: Fix timeout tests in au1xac97c_ac97_read()
Date: Mon, 15 Jan 2018 08:37:40 +0000 [thread overview]
Message-ID: <20180115083740.arvwplzroxvqy4qw@mwanda> (raw)
In-Reply-To: <CAOLZvyGXxOdpF9kx6FcHKgVEogAkb4q0QoncH6fPS_B2nae=QQ@mail.gmail.com>
On Mon, Jan 15, 2018 at 09:25:15AM +0100, Manuel Lauss wrote:
> On Mon, Jan 15, 2018 at 9:08 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > The loop timeout doesn't work because it's a post op and ends with "tmo"
> > set to -1. I changed it from a post-op to a pre-op and I changed the
> > initial the starting value from 5 to 6 so we still iterate 5 times. I
> > left the other as it was because it's a large number.
> >
> > Fixes: b3c70c9ea62a ("ASoC: Alchemy AC97C/I2SC audio support")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Ackey-by: Manuel Lauss <manuel.lauss@gmail.com>
>
> I didn't notice any failures with latest -git though, I've never
> actually hit these
> timeouts, even under maximum CPU load.
>
Yeah. These are static checker fixes, not something I hit in real life.
regards,
dan carpenter
next prev parent reply other threads:[~2018-01-15 8:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 8:08 [PATCH] ASoC: au1x: Fix timeout tests in au1xac97c_ac97_read() Dan Carpenter
2018-01-15 8:25 ` Manuel Lauss
2018-01-15 8:37 ` Dan Carpenter [this message]
2018-01-16 13:57 ` Applied "ASoC: au1x: Fix timeout tests in au1xac97c_ac97_read()" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115083740.arvwplzroxvqy4qw@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=manuel.lauss@gmail.com \
--cc=manuel.lauss@googlemail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox