From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Date: Thu, 18 Jan 2018 14:08:01 +0000 Subject: Re: [PATCH -next] mtd: ubi: wl: Fix error return code in ubi_wl_init() Message-Id: <20180118150801.714ecc34@bbrezillon> List-Id: References: <1516284305-82544-1-git-send-email-weiyongjun1@huawei.com> In-Reply-To: <1516284305-82544-1-git-send-email-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wei Yongjun Cc: Artem Bityutskiy , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Thu, 18 Jan 2018 14:05:05 +0000 Wei Yongjun wrote: > Fix to return error code -ENOMEM from the kmem_cache_alloc() error > handling case instead of 0, as done elsewhere in this function. I guess you've used a static analysis code to detect this problem, can you name it in the commit message, and paste the error/warning message it reported next time you submit this kind of patch. > > Signed-off-by: Wei Yongjun NAck. I you read the code you'll see that err is initialized to -ENOMEM here [1], so these changes are actually not needed. > --- > drivers/mtd/ubi/wl.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c > index 77ab49f..2052a64 100644 > --- a/drivers/mtd/ubi/wl.c > +++ b/drivers/mtd/ubi/wl.c > @@ -1617,8 +1617,10 @@ int ubi_wl_init(struct ubi_device *ubi, struct ubi_attach_info *ai) > cond_resched(); > > e = kmem_cache_alloc(ubi_wl_entry_slab, GFP_KERNEL); > - if (!e) > + if (!e) { > + err = -ENOMEM; > goto out_free; > + } > > e->pnum = aeb->pnum; > e->ec = aeb->ec; > @@ -1637,8 +1639,10 @@ int ubi_wl_init(struct ubi_device *ubi, struct ubi_attach_info *ai) > cond_resched(); > > e = kmem_cache_alloc(ubi_wl_entry_slab, GFP_KERNEL); > - if (!e) > + if (!e) { > + err = -ENOMEM; > goto out_free; > + } > > e->pnum = aeb->pnum; > e->ec = aeb->ec; > [1]https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/mtd/ubi/wl.c?h=next-20180118#n1596