From: Steven Rostedt <rostedt@goodmis.org>
To: "Christopher Díaz Riveros" <chrisadr@gentoo.org>
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
Randy Dunlap <rdunlap@infradead.org>,
mingo@kernel.org, akpm@linux-foundation.org, tglx@linutronix.de,
keescook@chromium.org, lauraa@codeaurora.org, mhocko@suse.com,
tal.shorer@gmail.com, viresh.kumar@linaro.org,
lokeshvutla@ti.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH-next] init/main.c: make local symbol static
Date: Fri, 19 Jan 2018 00:31:34 +0000 [thread overview]
Message-ID: <20180118193134.59135fde@gandalf.local.home> (raw)
In-Reply-To: <1516318407.2510.76.camel@gentoo.org>
On Thu, 18 Jan 2018 18:33:27 -0500
Christopher DÃaz Riveros <chrisadr@gentoo.org> wrote:
> > > What about the other user(s) of envp_init?
> >
> > It looks like it's referenced in init/do_mounts_initrd.c. Rather
> > than making it static, it should be declared in .h file.
> >
>
> Ok, I'll try to figure it out, akpm accepted the patch in mm-next but
> was dropped because of testing failures. I'm still very new to all of
> this process.
Yeah, because do_mounts_initrd.c didn't compile. If you do add it to a
header, use a header local in the init directory. Do not expose
envp_init to the entire kernel.
-- Steve
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-01-19 0:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 22:06 [PATCH-next] init/main.c: make local symbol static Christopher Díaz Riveros
2018-01-18 22:09 ` Randy Dunlap
2018-01-18 22:31 ` Tom Lendacky
2018-01-18 23:33 ` Christopher Díaz Riveros
2018-01-18 23:35 ` Randy Dunlap
2018-01-19 0:31 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180118193134.59135fde@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=chrisadr@gentoo.org \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lauraa@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=rdunlap@infradead.org \
--cc=tal.shorer@gmail.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox