From: Miquel Raynal <miquel.raynal@free-electrons.com>
To: walter harms <wharms@bfs.de>
Cc: kernel-janitors@vger.kernel.org,
Colin King <colin.king@canonical.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH][next] mtd: nand: fix spelling mistake: "suceed"-> "succeed"
Date: Fri, 19 Jan 2018 07:39:52 +0000 [thread overview]
Message-ID: <20180119083952.23c4baeb@xps13> (raw)
In-Reply-To: <5A5DDCA0.1000908@bfs.de>
Hello,
Can you please change the prefix, it should be:
mtd: nand: marvell:
On Tue, 16 Jan
2018 12:06:08 +0100 walter harms <wharms@bfs.de> wrote:
> Am 16.01.2018 11:28, schrieb Colin King:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Trivial fix to spelling mistakes in dev_err error message text.
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/mtd/nand/marvell_nand.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/nand/marvell_nand.c
> > b/drivers/mtd/nand/marvell_nand.c index b8fec6093b75..4bd53b360277
> > 100644 --- a/drivers/mtd/nand/marvell_nand.c
> > +++ b/drivers/mtd/nand/marvell_nand.c
> > @@ -517,7 +517,7 @@ static int marvell_nfc_prepare_cmd(struct
> > nand_chip *chip) /* Poll ND_RUN and clear NDSR before issuing any
> > command */ ret = marvell_nfc_wait_ndrun(chip);
> > if (ret) {
> > - dev_err(nfc->dev, "Last operation did not
> > suceed\n");
> > + dev_err(nfc->dev, "Last operation did not
> > succeed\n"); return ret;
> > }
> >
>
> not succeed = Failed ??
I personally do not have a preference, as long as there is a clear
error message in this case.
> someone who is debugging may also interessted to know what operation
> failed.
It is not as easy to do, but starting from enabling dynamic debug in
both the driver and the NAND core should give you enough traces to
locate the issue.
Thanks,
Miquèl
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-01-19 7:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 10:28 [PATCH][next] mtd: nand: fix spelling mistake: "suceed"-> "succeed" Colin King
2018-01-16 11:06 ` walter harms
2018-01-19 7:39 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119083952.23c4baeb@xps13 \
--to=miquel.raynal@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=colin.king@canonical.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox