From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Date: Fri, 19 Jan 2018 07:39:52 +0000 Subject: Re: [PATCH][next] mtd: nand: fix spelling mistake: "suceed"-> "succeed" Message-Id: <20180119083952.23c4baeb@xps13> List-Id: References: <20180116102808.23232-1-colin.king@canonical.com> <5A5DDCA0.1000908@bfs.de> In-Reply-To: <5A5DDCA0.1000908@bfs.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: walter harms Cc: kernel-janitors@vger.kernel.org, Colin King , Boris Brezillon , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , linux-mtd@lists.infradead.org Hello, Can you please change the prefix, it should be: mtd: nand: marvell: On Tue, 16 Jan 2018 12:06:08 +0100 walter harms wrote: > Am 16.01.2018 11:28, schrieb Colin King: > > From: Colin Ian King > >=20 > > Trivial fix to spelling mistakes in dev_err error message text. > >=20 > > Signed-off-by: Colin Ian King > > --- > > drivers/mtd/nand/marvell_nand.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/drivers/mtd/nand/marvell_nand.c > > b/drivers/mtd/nand/marvell_nand.c index b8fec6093b75..4bd53b360277 > > 100644 --- a/drivers/mtd/nand/marvell_nand.c > > +++ b/drivers/mtd/nand/marvell_nand.c > > @@ -517,7 +517,7 @@ static int marvell_nfc_prepare_cmd(struct > > nand_chip *chip) /* Poll ND_RUN and clear NDSR before issuing any > > command */ ret =3D marvell_nfc_wait_ndrun(chip); > > if (ret) { > > - dev_err(nfc->dev, "Last operation did not > > suceed\n"); > > + dev_err(nfc->dev, "Last operation did not > > succeed\n"); return ret; > > } > > =20 >=20 > not succeed =3D Failed ?? I personally do not have a preference, as long as there is a clear error message in this case. > someone who is debugging may also interessted to know what operation > failed. It is not as easy to do, but starting from enabling dynamic debug in both the driver and the NAND core should give you enough traces to locate the issue. Thanks, Miqu=C3=A8l -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html