From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Date: Fri, 19 Jan 2018 08:05:18 +0000 Subject: Re: [PATCH][V2] mtd: nand: marvell: remove redundant variable 'oob_len' Message-Id: <20180119090518.619e3d44@xps13> List-Id: References: <20180119075954.15009-1-colin.king@canonical.com> In-Reply-To: <20180119075954.15009-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Colin King Cc: Boris Brezillon , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org Hello, On Fri, 19 Jan 2018 07:59:54 +0000 Colin King wrote: > From: Colin Ian King >=20 > Variable oob_len is assigned and never read, hence it is redundant and > can be removed. >=20 > Cleans up clang warnings: >=20 > drivers/mtd/nand/marvell_nand.c:1356:6: warning: Value stored to 'oob_len' > during its initialization is never read > drivers/mtd/nand/marvell_nand.c:1369:4: warning: Value stored to 'oob_len' > is never read >=20 > Signed-off-by: Colin Ian King > --- > drivers/mtd/nand/marvell_nand.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/drivers/mtd/nand/marvell_nand.c b/drivers/mtd/nand/marvell_n= and.c > index 4bd53b360277..f15ab37edf4e 100644 > --- a/drivers/mtd/nand/marvell_nand.c > +++ b/drivers/mtd/nand/marvell_nand.c > @@ -1353,7 +1353,6 @@ static int marvell_nfc_hw_ecc_bch_write_page_raw(st= ruct mtd_info *mtd, > int data_len =3D lt->data_bytes; > int spare_len =3D lt->spare_bytes; > int ecc_len =3D lt->ecc_bytes; > - int oob_len =3D spare_len + ecc_len; > int spare_offset =3D 0; > int ecc_offset =3D (lt->full_chunk_cnt * lt->spare_bytes) + > lt->last_spare_bytes; > @@ -1366,7 +1365,6 @@ static int marvell_nfc_hw_ecc_bch_write_page_raw(st= ruct mtd_info *mtd, > data_len =3D lt->last_data_bytes; > spare_len =3D lt->last_spare_bytes; > ecc_len =3D lt->last_ecc_bytes; > - oob_len =3D spare_len + ecc_len; > } > =20 > /* Point to the column of the next chunk */ Acked-by: Miquel Raynal Thanks, Miqu=C3=A8l -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html