From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] mtd: onenand: omap2: Remove redundant dev_err call in omap2_onenand_probe()
Date: Sat, 20 Jan 2018 13:49:06 +0000 [thread overview]
Message-ID: <20180120144906.3d22a204@bbrezillon> (raw)
In-Reply-To: <1516188333-144550-1-git-send-email-weiyongjun1@huawei.com>
On Wed, 17 Jan 2018 11:25:33 +0000
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
Applied.
Thanks,
Boris
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/mtd/onenand/omap2.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
> index a4a2159..87c34f6 100644
> --- a/drivers/mtd/onenand/omap2.c
> +++ b/drivers/mtd/onenand/omap2.c
> @@ -532,10 +532,8 @@ static int omap2_onenand_probe(struct platform_device *pdev)
> c->phys_base = res->start;
>
> c->onenand.base = devm_ioremap_resource(dev, res);
> - if (IS_ERR(c->onenand.base)) {
> - dev_err(dev, "Cannot reserve memory region %pR\n", res);
> + if (IS_ERR(c->onenand.base))
> return PTR_ERR(c->onenand.base);
> - }
>
> c->int_gpiod = devm_gpiod_get_optional(dev, "int", GPIOD_IN);
> if (IS_ERR(c->int_gpiod)) {
>
>
>
prev parent reply other threads:[~2018-01-20 13:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 11:25 [PATCH -next] mtd: onenand: omap2: Remove redundant dev_err call in omap2_onenand_probe() Wei Yongjun
2018-01-20 13:49 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180120144906.3d22a204@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox