From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Date: Thu, 01 Feb 2018 22:50:15 +0000 Subject: Re: [PATCH] RDMA/nldev: missing error code in nldev_res_get_doit() Message-Id: <20180201225015.GC8590@ziepe.ca> List-Id: References: <20180201100148.GA8959@mwanda> In-Reply-To: <20180201100148.GA8959@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Doug Ledford , Leon Romanovsky , Steve Wise , Mark Bloch , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org On Thu, Feb 01, 2018 at 01:01:48PM +0300, Dan Carpenter wrote: > We should return -ENOMEM if the allocation fails. The current code > accidentally returns success. > > Fixes: bf3c5a93c523 ("RDMA/nldev: Provide global resource utilization") > Signed-off-by: Dan Carpenter > Reviewed-by: Leon Romanovsky Applied to for-next, thanks Jason