From: Darren Hart <dvhart@infradead.org>
To: Vadim Pasternak <vadimp@mellanox.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Andy Shevchenko <andy@infradead.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: mlx-platform: Fix an ERR_PTR vs NULL issue
Date: Tue, 06 Feb 2018 15:42:04 +0000 [thread overview]
Message-ID: <20180206154204.GB11119@fury> (raw)
In-Reply-To: <AM4PR05MB3330D53BBA5BD43AF7EE6D7DA2FD0@AM4PR05MB3330.eurprd05.prod.outlook.com>
On Tue, Feb 06, 2018 at 12:55:58PM +0000, Vadim Pasternak wrote:
>
>
> > -----Original Message-----
> > From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> > Sent: Tuesday, February 06, 2018 2:46 PM
> > To: Vadim Pasternak <vadimp@mellanox.com>
> > Cc: Darren Hart <dvhart@infradead.org>; Andy Shevchenko
> > <andy@infradead.org>; platform-driver-x86@vger.kernel.org; kernel-
> > janitors@vger.kernel.org
> > Subject: [PATCH] platform/x86: mlx-platform: Fix an ERR_PTR vs NULL issue
> >
> > devm_ioport_map() returns NULL on error but we accidentally check for error
> > pointers instead.
> >
> > Fixes: c6acad68eb2d ("platform/mellanox: mlxreg-hotplug: Modify to use a
> > regmap interface")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Acked-by: Vadim Pasternak <vadimp@melanox.com>
Queued up for today's PR for 4.16. Thanks.
--
Darren Hart
VMware Open Source Technology Center
prev parent reply other threads:[~2018-02-06 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 12:45 [PATCH] platform/x86: mlx-platform: Fix an ERR_PTR vs NULL issue Dan Carpenter
2018-02-06 12:55 ` Vadim Pasternak
2018-02-06 15:42 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206154204.GB11119@fury \
--to=dvhart@infradead.org \
--cc=andy@infradead.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox