From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Date: Mon, 19 Feb 2018 17:37:14 +0000 Subject: Re: [PATCH][V2] net: dsa: mv88e6xxx: avoid unintended sign extension on a 16 bit shift Message-Id: <20180219173714.6frfl3nfq3gi4jsv@localhost> List-Id: References: <20180216165505.20058-1-colin.king@canonical.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Laight Cc: 'Colin King' , Andrew Lunn , Vivien Didelot , Florian Fainelli , "netdev@vger.kernel.org" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" On Mon, Feb 19, 2018 at 12:19:16PM +0000, David Laight wrote: > This seems to be somewhat excessive 64bit maths on a 32bit system. > It is more than enough to make timelo/timehi 'unsigned int'. Do you see a difference in the generated code? Thanks, Richard