public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: David Disseldorp <ddiss@suse.de>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH 0/8] target-iSCSI: Adjustments for several function implementations
Date: Thu, 22 Feb 2018 13:36:24 +0000	[thread overview]
Message-ID: <20180222143624.7c7241a1@suse.de> (raw)
In-Reply-To: <6163538d-a406-2f60-11a2-88b4694e9975@users.sourceforge.net>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 1335 bytes --]

[cc list trimmed]

On Wed, 21 Feb 2018 17:45:35 +0100, SF Markus Elfring wrote:

...
> One of these update suggestions resulted in the commit “target: avoid NULL
> dereference in CHAP auth error path” which is considered for integration
> into Linux stable versions now.
> https://patchwork.kernel.org/patch/10110459/
> https://lkml.kernel.org/r/<20171213172230.12767-1-ddiss@suse.de>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/target/iscsi/iscsi_target_auth.c?idÎ512d79d0466a604793addb6b769d12ee326822

You're 1/8 patch had an actual bug fix hidden amongst the style churn.
I don't see any such fixes in the other patches.

> Now I am curious if more remaining change possibilities can be picked up
> from this patch series.
> 
> * Would you like to improve any more implementation details?
> 
> * Do you need additional explanations for further benefits?

My opinion from https://www.spinics.net/lists/target-devel/msg16342.html
hasn't changed. FWIW, I'd prefer to see LIO adopt a policy similar to:
https://btrfs.wiki.kernel.org/index.php/Developer%27s_FAQ#How_not_to_start

Cheers, David
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2018-02-22 13:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-12 21:40 [PATCH 0/8] target-iSCSI: Adjustments for several function implementations SF Markus Elfring
2017-12-12 21:42 ` [PATCH 1/8] target/iscsi: Less function calls in chap_server_compute_md5() after error detection SF Markus Elfring
2017-12-12 21:43 ` [PATCH 2/8] target/iscsi: Move resetting of seven variables in chap_server_compute_md5() SF Markus Elfring
2017-12-12 21:45 ` [PATCH 3/8] target/iscsi: Delete 36 error messages for a failed memory allocation SF Markus Elfring
2017-12-12 21:46 ` [PATCH 4/8] target/iscsi: Delete an unnecessary variable initialisation in iscsit_allocate_ooo_cmdsn SF Markus Elfring
2017-12-12 21:47 ` [PATCH 5/8] target/iscsi: Delete an unnecessary variable initialisation in iscsi_copy_param_list() SF Markus Elfring
2017-12-12 21:49 ` [PATCH 6/8] target/iscsi: Delete an unnecessary variable initialisation in iscsi_create_default_para SF Markus Elfring
2017-12-12 21:50 ` [PATCH 7/8] target/iscsi: Delete an unnecessary variable initialisation in iscsi_set_default_param() SF Markus Elfring
2017-12-12 21:52 ` [PATCH 8/8] target/iscsi: Improve 16 size determinations SF Markus Elfring
2018-02-21 16:45 ` [PATCH 0/8] target-iSCSI: Adjustments for several function implementations SF Markus Elfring
2018-02-22 13:36 ` David Disseldorp [this message]
2018-02-23  8:19   ` [0/8] " SF Markus Elfring
2018-02-22 13:56 ` [PATCH 0/8] " Dan Carpenter
2018-02-23  9:06   ` [0/8] " SF Markus Elfring
2018-02-23 10:17     ` Dan Carpenter
2018-02-23 11:50       ` SF Markus Elfring
2018-02-22 14:19 ` [PATCH 0/8] " David Disseldorp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180222143624.7c7241a1@suse.de \
    --to=ddiss@suse.de \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox