* [PATCH] media: em28xx-cards: fix em28xx_duplicate_dev()
@ 2018-03-08 9:31 Dan Carpenter
2018-03-08 14:11 ` Brad Love
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2018-03-08 9:31 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Brad Love; +Cc: linux-media, kernel-janitors
There is a double sizeof() typo here so we don't duplicate the struct
properly.
Fixes: be7fd3c3a8c5 ("media: em28xx: Hauppauge DualHD second tuner functionality")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb/em28xx/em28xx-cards.c
index 6e8247849c4f..6e0e67d23876 100644
--- a/drivers/media/usb/em28xx/em28xx-cards.c
+++ b/drivers/media/usb/em28xx/em28xx-cards.c
@@ -3515,7 +3515,7 @@ static int em28xx_duplicate_dev(struct em28xx *dev)
dev->dev_next = NULL;
return -ENOMEM;
}
- memcpy(sec_dev, dev, sizeof(sizeof(*sec_dev)));
+ memcpy(sec_dev, dev, sizeof(*sec_dev));
/* Check to see next free device and mark as used */
do {
nr = find_first_zero_bit(em28xx_devused, EM28XX_MAXBOARDS);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] media: em28xx-cards: fix em28xx_duplicate_dev()
2018-03-08 9:31 [PATCH] media: em28xx-cards: fix em28xx_duplicate_dev() Dan Carpenter
@ 2018-03-08 14:11 ` Brad Love
0 siblings, 0 replies; 2+ messages in thread
From: Brad Love @ 2018-03-08 14:11 UTC (permalink / raw)
To: Dan Carpenter, Mauro Carvalho Chehab, Brad Love
Cc: linux-media, kernel-janitors
Hi Dan,
On 2018-03-08 03:31, Dan Carpenter wrote:
> There is a double sizeof() typo here so we don't duplicate the struct
> properly.
>
> Fixes: be7fd3c3a8c5 ("media: em28xx: Hauppauge DualHD second tuner functionality")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb/em28xx/em28xx-cards.c
> index 6e8247849c4f..6e0e67d23876 100644
> --- a/drivers/media/usb/em28xx/em28xx-cards.c
> +++ b/drivers/media/usb/em28xx/em28xx-cards.c
> @@ -3515,7 +3515,7 @@ static int em28xx_duplicate_dev(struct em28xx *dev)
> dev->dev_next = NULL;
> return -ENOMEM;
> }
> - memcpy(sec_dev, dev, sizeof(sizeof(*sec_dev)));
> + memcpy(sec_dev, dev, sizeof(*sec_dev));
> /* Check to see next free device and mark as used */
> do {
> nr = find_first_zero_bit(em28xx_devused, EM28XX_MAXBOARDS);
Ouch, good catch. Strangely everything still worked in 64bit builds, and
I've had no reports of wonky behaviour elsewhere.
Cheers,
Brad
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-08 14:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-08 9:31 [PATCH] media: em28xx-cards: fix em28xx_duplicate_dev() Dan Carpenter
2018-03-08 14:11 ` Brad Love
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox