* [PATCH 0/2] net/usb/ax88179_178a: Adjustments for ax88179_chk_eee()
@ 2018-03-10 18:22 SF Markus Elfring
2018-03-10 19:17 ` Andrew Lunn
0 siblings, 1 reply; 2+ messages in thread
From: SF Markus Elfring @ 2018-03-10 18:22 UTC (permalink / raw)
To: linux-usb, netdev, Andrew F. Davis, Bjørn Mork,
David S. Miller, Philippe Reynes, Yuval Shaia
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 10 Mar 2018 19:05:45 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Use common code
Delete three unnecessary variables
drivers/net/usb/ax88179_178a.c | 45 +++++++++++++++---------------------------
1 file changed, 16 insertions(+), 29 deletions(-)
--
2.16.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 0/2] net/usb/ax88179_178a: Adjustments for ax88179_chk_eee()
2018-03-10 18:22 [PATCH 0/2] net/usb/ax88179_178a: Adjustments for ax88179_chk_eee() SF Markus Elfring
@ 2018-03-10 19:17 ` Andrew Lunn
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2018-03-10 19:17 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-usb, netdev, Andrew F. Davis, Bjørn Mork,
David S. Miller, Philippe Reynes, Yuval Shaia, LKML,
kernel-janitors
On Sat, Mar 10, 2018 at 07:22:55PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 10 Mar 2018 19:05:45 +0100
>
> Two update suggestions were taken into account
> from static source code analysis.
Hi Markus
How about re-writing this driver to use phylib. The whole of
ax88179_chk_eee() would then go away, since it is a duplication of
phy_init_eee().
Andrew
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-10 19:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-10 18:22 [PATCH 0/2] net/usb/ax88179_178a: Adjustments for ax88179_chk_eee() SF Markus Elfring
2018-03-10 19:17 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox