* [PATCH] drm: zte: Fix an error handling path in 'zx_crtc_bind()'
@ 2018-03-11 22:32 Christophe JAILLET
2018-03-12 7:35 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2018-03-11 22:32 UTC (permalink / raw)
To: shawnguo, airlied
Cc: dri-devel, linux-kernel, kernel-janitors, Christophe JAILLET
'ret' is known to be 0 at this point. It must be updated by the value
returned by 'clk_prepare_enable()'.
Fixes: 0a886f59528a ("drm: zte: add initial vou drm driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/gpu/drm/zte/zx_vou.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/zte/zx_vou.c b/drivers/gpu/drm/zte/zx_vou.c
index 7491813131f3..3351b258ed7a 100644
--- a/drivers/gpu/drm/zte/zx_vou.c
+++ b/drivers/gpu/drm/zte/zx_vou.c
@@ -838,7 +838,7 @@ static int zx_crtc_bind(struct device *dev, struct device *master, void *data)
return ret;
}
- clk_prepare_enable(vou->ppu_clk);
+ ret = clk_prepare_enable(vou->ppu_clk);
if (ret) {
DRM_DEV_ERROR(dev, "failed to enable ppu_clk: %d\n", ret);
goto disable_axi_clk;
--
2.14.1
---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: zte: Fix an error handling path in 'zx_crtc_bind()'
2018-03-11 22:32 [PATCH] drm: zte: Fix an error handling path in 'zx_crtc_bind()' Christophe JAILLET
@ 2018-03-12 7:35 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2018-03-12 7:35 UTC (permalink / raw)
To: Christophe JAILLET, Daniel Vetter
Cc: airlied, kernel-janitors, linux-kernel, dri-devel
+ Daniel
On Sun, Mar 11, 2018 at 11:32:03PM +0100, Christophe JAILLET wrote:
> 'ret' is known to be 0 at this point. It must be updated by the value
> returned by 'clk_prepare_enable()'.
>
> Fixes: 0a886f59528a ("drm: zte: add initial vou drm driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Shawn Guo <shawnguo@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-12 7:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-11 22:32 [PATCH] drm: zte: Fix an error handling path in 'zx_crtc_bind()' Christophe JAILLET
2018-03-12 7:35 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox