From: Darren Hart <dvhart@infradead.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86: Fix memory leaks in build_tokens_sysfs()
Date: Fri, 16 Mar 2018 21:52:38 +0000 [thread overview]
Message-ID: <20180316215238.GA41192@localhost.localdomain> (raw)
In-Reply-To: <20180316121015.GA14282@mwanda>
On Fri, Mar 16, 2018 at 08:35:44PM +0200, Andy Shevchenko wrote:
> On Fri, Mar 16, 2018 at 2:10 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > We're freeing "value_name" which is NULL, so that's a no-op, but we
> > intended to free "location_name" instead. And then we don't free the
> > names in token_location_attrs[0] and token_value_attrs[0].
> >
> > Fixes: 33b9ca1e53b4 ("platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > v2: style changes (move from a for loop to a while loop) and this driver
> > has been renamed.
> >
> > diff --git a/drivers/platform/x86/dell-smbios-base.c b/drivers/platform/x86/dell-smbios-base.c
> > index 2485c80a9fdd..ec31d149f82e 100644
> > --- a/drivers/platform/x86/dell-smbios-base.c
> > +++ b/drivers/platform/x86/dell-smbios-base.c
> > @@ -514,7 +514,7 @@ static int build_tokens_sysfs(struct platform_device *dev)
> > continue;
> >
> > loop_fail_create_value:
> > - kfree(value_name);
> > + kfree(location_name);
> > goto out_unwind_strings;
> > }
> > smbios_attribute_group.attrs = token_attrs;
> > @@ -525,7 +525,7 @@ static int build_tokens_sysfs(struct platform_device *dev)
> > return 0;
> >
> > out_unwind_strings:
> > - for (i = i-1; i > 0; i--) {
> > + while (--i >= 0) {
>
> Simple
>
> while (i--) {
Yeah, i starts at 0 and is not decremented anywhere but here, so i--
seems sufficient to me.
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2018-03-16 21:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 12:10 [PATCH v2] platform/x86: Fix memory leaks in build_tokens_sysfs() Dan Carpenter
2018-03-16 18:35 ` Andy Shevchenko
2018-03-16 21:52 ` Darren Hart [this message]
2018-03-17 4:33 ` Dan Carpenter
2018-04-02 15:30 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316215238.GA41192@localhost.localdomain \
--to=dvhart@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox