From mboxrd@z Thu Jan 1 00:00:00 1970 From: William Breathitt Gray Date: Wed, 18 Apr 2018 17:40:43 +0000 Subject: Re: [PATCH] gpio: make several const arrays static, shrinks object size Message-Id: <20180418174043.GA15833@sophia> List-Id: References: <20180418172634.14734-1-colin.king@canonical.com> In-Reply-To: <20180418172634.14734-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Linus Walleij , linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, Apr 18, 2018 at 06:26:34PM +0100, Colin King wrote: >From: Colin Ian King > >Don't populate the const read-only arrays 'port' on the stack but >instead make them static. Makes the object code smaller: > >Before: > text data bss dec hex filename > 8542 4088 672 13302 33f6 drivers/gpio/gpio-gpio-mm.o > 10959 4952 832 16743 4167 drivers/gpio/gpio-104-dio-48e.o > 9022 5064 1408 15494 3c86 drivers/gpio/gpio-104-idi-48.o > >After: > text data bss dec hex filename > 8372 4144 672 13188 3384 drivers/gpio/gpio-gpio-mm.o > 10790 5008 832 16630 40f6 drivers/gpio/gpio-104-dio-48e.o > 8853 5152 1408 15413 3c35 linux/drivers/gpio/gpio-104-idi-48.o > >(gcc version 7.2.0 x86_64) > >Signed-off-by: Colin Ian King Acked-by: William Breathitt Gray