Re: [PATCH] mfd: tps65911-comparator: Fix an off by one bug

Dan Carpenter
2018-04-20T08:21:50Z

On Fri, Apr 20, 2018 at 09:09:43AM +0100, Lee Jones wrote:
> On Thu, 19 Apr 2018, Dan Carpenter wrote:
>
> > The tps_comparators[] array is used in two places. We only access the
> > COMP1 (1) and COMP2 (2) elements. Unfortunately, we're accessing the
> > wrong elements and also one element beyond the end of the array. There
> > was supposed to be a zero element at the start of the array which is
> > isn't accessed but makes the math work out nicely.
>
> I normally just apply patches from you, but this is a hack, right?
>

I liked it, I thought it was nice. It uses 32 bytes but any fix was
going to use *some* memory. I don't have strong feelings about it
though, if you want to write a different patch I can do that instead.

regards,
dan carpenter