From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] net/ipv6: separate handling of FIB entries from dst based routes
Date: Fri, 20 Apr 2018 11:19:16 +0000 [thread overview]
Message-ID: <20180420111916.GA18520@mwanda> (raw)
Hello David Ahern,
This is a semi-automatic email about new static checker warnings.
The patch 93531c674315: "net/ipv6: separate handling of FIB entries
from dst based routes" from Apr 17, 2018, leads to the following
Smatch complaint:
net/ipv6/route.c:2128 fib6_check()
error: we previously assumed 'f6i' could be null (see line 2124)
net/ipv6/route.c
2123 /*
2124 * Destination cache support functions
2125 */
2126
2127 static bool fib6_check(struct fib6_info *f6i, u32 cookie)
2128 {
2129 u32 rt_cookie = 0;
2130
2131 if ((f6i && !rt6_get_cookie_safe(f6i, &rt_cookie)) ||
^^^
Check
2132 rt_cookie != cookie)
2133 return false;
2134
2135 if (fib6_check_expired(f6i))
^^^
Unchecked dereference inside function.
2136 return false;
2137
2138 return true;
2139 }
regards,
dan carpenter
reply other threads:[~2018-04-20 11:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420111916.GA18520@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox