From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Date: Sun, 22 Apr 2018 17:29:21 +0000 Subject: Re: [PATCH 30/61] mtd: nand: onenand: simplify getting .drvdata Message-Id: <20180422192921.61a6b28b@bbrezillon> List-Id: References: <20180419140641.27926-1-wsa+renesas@sang-engineering.com> <20180419140641.27926-31-wsa+renesas@sang-engineering.com> In-Reply-To: <20180419140641.27926-31-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wolfram Sang Cc: linux-kernel@vger.kernel.org, Richard Weinberger , kernel-janitors@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Kyungmin Park , linux-mtd@lists.infradead.org, Brian Norris , David Woodhouse , Marek Vasut On Thu, 19 Apr 2018 16:06:00 +0200 Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang Applied to nand/next. Thanks, Boris > --- > > Build tested only. buildbot is happy. Please apply individually. > > drivers/mtd/nand/onenand/samsung.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/mtd/nand/onenand/samsung.c b/drivers/mtd/nand/onenand/samsung.c > index 2e9d076e445a..4cce4c0311ca 100644 > --- a/drivers/mtd/nand/onenand/samsung.c > +++ b/drivers/mtd/nand/onenand/samsung.c > @@ -958,8 +958,7 @@ static int s3c_onenand_remove(struct platform_device *pdev) > > static int s3c_pm_ops_suspend(struct device *dev) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct mtd_info *mtd = platform_get_drvdata(pdev); > + struct mtd_info *mtd = dev_get_drvdata(dev); > struct onenand_chip *this = mtd->priv; > > this->wait(mtd, FL_PM_SUSPENDED); > @@ -968,8 +967,7 @@ static int s3c_pm_ops_suspend(struct device *dev) > > static int s3c_pm_ops_resume(struct device *dev) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct mtd_info *mtd = platform_get_drvdata(pdev); > + struct mtd_info *mtd = dev_get_drvdata(dev); > struct onenand_chip *this = mtd->priv; > > this->unlock_all(mtd);